You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iotdb.apache.org by li...@apache.org on 2019/11/20 11:59:56 UTC

[incubator-iotdb] 01/02: refactor(IStatistic): remove unused interface

This is an automated email from the ASF dual-hosted git repository.

liurui pushed a commit to branch monitor
in repository https://gitbox.apache.org/repos/asf/incubator-iotdb.git

commit fe2a040ed8bacb5cde27917dad57d5c900a3b596
Author: liuruiyiyang <24...@qq.com>
AuthorDate: Wed Nov 20 15:48:31 2019 +0800

    refactor(IStatistic): remove unused interface
---
 .../org/apache/iotdb/db/engine/StorageEngine.java  | 30 +++++++++++++++++++++-
 .../org/apache/iotdb/db/monitor/IStatistic.java    |  7 -----
 2 files changed, 29 insertions(+), 8 deletions(-)

diff --git a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
index 392fdc1..4a8eeb1 100644
--- a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
+++ b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java
@@ -34,6 +34,7 @@ import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 import java.util.concurrent.ScheduledExecutorService;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicLong;
 import org.apache.commons.io.FileUtils;
 import org.apache.iotdb.db.concurrent.IoTDBThreadPoolFactory;
 import org.apache.iotdb.db.conf.IoTDBConfig;
@@ -51,6 +52,8 @@ import org.apache.iotdb.db.exception.storageGroup.StorageGroupException;
 import org.apache.iotdb.db.exception.storageGroup.StorageGroupProcessorException;
 import org.apache.iotdb.db.metadata.MManager;
 import org.apache.iotdb.db.metadata.MNode;
+import org.apache.iotdb.db.monitor.IStatistic;
+import org.apache.iotdb.db.monitor.MonitorConstants;
 import org.apache.iotdb.db.qp.physical.crud.BatchInsertPlan;
 import org.apache.iotdb.db.qp.physical.crud.InsertPlan;
 import org.apache.iotdb.db.query.context.QueryContext;
@@ -64,16 +67,27 @@ import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
 import org.apache.iotdb.tsfile.file.metadata.enums.TSEncoding;
 import org.apache.iotdb.tsfile.read.common.Path;
 import org.apache.iotdb.tsfile.read.expression.impl.SingleSeriesExpression;
+import org.apache.iotdb.tsfile.write.record.TSRecord;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-public class StorageEngine implements IService {
+public class StorageEngine implements IService, IStatistic {
 
   private final Logger logger;
   private static final IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
   private static final long TTL_CHECK_INTERVAL = 60 * 1000;
 
   /**
+   * the monitored metric's time series path prefix of this class
+   */
+  private static final String MONITOR_METRIC_PREFIX = MonitorConstants.STAT_STORAGE_DELTA_NAME;
+
+  /**
+   *
+   */
+  private static AtomicLong insertPoint = new AtomicLong(0);
+
+  /**
    * a folder (system/storage_groups/ by default) that persist system info. Each Storage Processor
    * will have a subfolder under the systemDir.
    */
@@ -437,4 +451,18 @@ public class StorageEngine implements IService {
     getProcessor(deletedTsfile.getParentFile().getName()).deleteTsfile(deletedTsfile);
   }
 
+  @Override
+  public Map<String, TSRecord> getAllStatisticsValue() {
+    return null;
+  }
+
+  @Override
+  public void registerStatMetadata() {
+
+  }
+
+  @Override
+  public Map<String, AtomicLong> getStatParamsHashMap() {
+    return null;
+  }
 }
diff --git a/server/src/main/java/org/apache/iotdb/db/monitor/IStatistic.java b/server/src/main/java/org/apache/iotdb/db/monitor/IStatistic.java
index f032571..af0d736 100644
--- a/server/src/main/java/org/apache/iotdb/db/monitor/IStatistic.java
+++ b/server/src/main/java/org/apache/iotdb/db/monitor/IStatistic.java
@@ -40,13 +40,6 @@ public interface IStatistic {
   void registerStatMetadata();
 
   /**
-   * Get all module's statistics parameters as a time-series seriesPath.
-   *
-   * @return a list of string like "root.stats.xxx.statisticsParams",
-   */
-  List<String> getAllPathForStatistic();
-
-  /**
    * Get a HashMap contains the names and values of the statistics parameters.
    * @return a HashMap contains the names and values of the statistics parameters
    */