You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@yetus.apache.org by "Suraj Acharya (JIRA)" <ji...@apache.org> on 2017/02/06 03:29:41 UTC

[jira] [Commented] (YETUS-203) include a link to the dockerfile used

    [ https://issues.apache.org/jira/browse/YETUS-203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15853464#comment-15853464 ] 

Suraj Acharya commented on YETUS-203:
-------------------------------------

[~Shanika] i am not sure how much you have finished in this patch.
But I think this will help you a bit
{code}
sacharya@sacharya-MBP:~/repos/yetus$ git diff
diff --git a/precommit/core.d/docker.sh b/precommit/core.d/docker.sh
index e933883..1fb6f3c 100755
--- a/precommit/core.d/docker.sh
+++ b/precommit/core.d/docker.sh
@@ -586,8 +586,9 @@ PatchSpecificDocker

   client=$(docker_version Client)
   server=$(docker_version Server)
-
-  dockerversion="Client=${client} Server=${server}"
+  dockerversion="Client=${client} Server=${server} ${DOCKERFILE}"
   if [[ ${PATCH_DIR} =~ ^/ ]]; then
     exec "${DOCKERCMD}" run --rm=true -i \
       "${DOCKER_EXTRAARGS[@]}" \

{code}
{code:title=Output}
|| Subsystem || Report/Notes ||
============================================================================
| Docker | Client=1.13.0 Server=1.13.0 /private/tmp/yetus-6555.19571/precommit/test-patch-docker/Dockerfile Image:yetus/unknown:e4e4903 |
{code}
Hope this helps you.
If you have questions feel free to ask.

> include a link to the dockerfile used
> -------------------------------------
>
>                 Key: YETUS-203
>                 URL: https://issues.apache.org/jira/browse/YETUS-203
>             Project: Yetus
>          Issue Type: Improvement
>          Components: Test Patch
>            Reporter: Allen Wittenauer
>            Assignee: Shanika Ediriweera
>            Priority: Trivial
>
> We should include a link to the dockerfile that was used.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)