You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/10 07:42:24 UTC
[GitHub] [shardingsphere] Jacob953 commented on a diff in pull request #22055: Replace cases with results while dynamic loading SQL cases
Jacob953 commented on code in PR #22055:
URL: https://github.com/apache/shardingsphere/pull/22055#discussion_r1018745171
##########
test/integration-test/sql-parser/src/test/java/org/apache/shardingsphere/sql/parser/base/DynamicLoadingSQLParserParameterizedTest.java:
##########
@@ -81,12 +81,12 @@ protected static Collection<Map<String, String>> getResponse(final String sqlCas
List<String> casesName = JsonPath.parse(caseContent).read("$..name");
List<String> casesDownloadURL = JsonPath.parse(caseContent).read("$..download_url");
List<String> casesHtmlURL = JsonPath.parse(caseContent).read("$..html_url");
+ List<String> casesType = JsonPath.parse(caseContent).read("$..type");
IntStream.range(0, JsonPath.parse(caseContent).read("$.length()"))
.forEach(each -> {
- String eachName = casesName.get(each);
- if (eachName.endsWith(".sql") || eachName.endsWith(".test")) {
- result.add(ImmutableMap.of("name", eachName, "download_url", casesDownloadURL.get(each)));
- } else if (!eachName.contains(".")) {
+ if (casesType.get(each).equals("file")) {
Review Comment:
fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org