You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/07/23 09:02:01 UTC

[PR] Mark KubernetesPodOperator and AgentOperator as durable capable [airflow]

amoghrajesh opened a new pull request, #70289:
URL: https://github.com/apache/airflow/pull/70289

    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull request.
   Write a good git commit message following this guide: https://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the documentation.
   
   For user-facing UI changes, please attach before/after screenshots (or a short
   screen recording) so reviewers can assess the visual impact.
   
   Feel free to ping (in general) for the review if you do not see reaction for a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, please
   change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
   -->
   
   - [x] Yes claude sonnet
   
   <!--
   Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   
   ---
   
   ### What
   
   
   Enhancement to: https://github.com/apache/airflow/pull/69651 where the Airflow Registry added a `supports_durable_execution` signal (built on top of `ResumableJobMixin`), badging operators that survive a worker crash/retry without redoing expensive work. `KubernetesPodOperator` (#69914) and `AgentOperator` (`common.ai`) both already implement this same crash-safe property, but neither inherits `ResumableJobMixin` and they implement it directly against `task_state_store`, since their own execution shapes (pod lifecycle management, LLM step/tool-call replay caching) don't fit the mixin's submit/poll/result contract. 
   
   The registry detection is purely MRO-based, so both operators are currently invisible to it despite genuinely qualifying.
   
   ### Proposed change
   
   Adds `_supports_durable_execution: ClassVar[bool] = True` directly to both operator classes indicating that durable execution is implemented directly here, not via `ResumableJobMixin`. This is a plain class attribute, not a new mixin or shared marker class -- there's no common contract between pod-lifecycle management and LLM-call caching to anchor a reusable base class on, so a class-level declaration is the simplest correct signal.
   
   ### Changes of Note
   
   This attribute is not read by anything yet. It will be a follow-up change, not part of this PR.
   
   ### What's next
   
   A follow-up change to `dev/registry/extract_parameters.py`'s `is_durable_capable()` to also treat `_supports_durable_execution = True` as qualifying, so these two operators actually surface in the Registry.
   
   
   ---
   
   * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Mark KubernetesPodOperator and AgentOperator as durable capable [airflow]

Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #70289:
URL: https://github.com/apache/airflow/pull/70289#discussion_r3638903162


##########
providers/common/ai/tests/unit/common/ai/operators/test_agent.py:
##########
@@ -759,6 +759,9 @@ def test_cleanup_skipped_when_post_run_step_fails(self, mock_hook_cls, mock_buil
 
         storage.cleanup.assert_not_called()
 
+    def test_supports_durable_execution_marker(self):
+        assert AgentOperator.__supports_durable_execution is True

Review Comment:
   ```suggestion
           assert AgentOperator._AgentOperator__supports_durable_execution is True
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Mark KubernetesPodOperator and AgentOperator as durable capable [airflow]

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #70289:
URL: https://github.com/apache/airflow/pull/70289


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Mark KubernetesPodOperator and AgentOperator as durable capable [airflow]

Posted by "phanikumv (via GitHub)" <gi...@apache.org>.
phanikumv commented on code in PR #70289:
URL: https://github.com/apache/airflow/pull/70289#discussion_r3638899394


##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_pod.py:
##########
@@ -2776,6 +2776,9 @@ def test_reattach_on_restart_via_default_args_reaches_durable(self, dag_maker):
         assert k.durable is False
         assert k.reattach_on_restart is False
 
+    def test_supports_durable_execution_marker(self):
+        assert KubernetesPodOperator.__supports_durable_execution is True

Review Comment:
   ```suggestion
           assert KubernetesPodOperator._KubernetesPodOperator__supports_durable_execution is True
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Mark KubernetesPodOperator and AgentOperator as durable capable [airflow]

Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #70289:
URL: https://github.com/apache/airflow/pull/70289#discussion_r3643214856


##########
providers/cncf/kubernetes/tests/unit/cncf/kubernetes/operators/test_pod.py:
##########
@@ -2776,6 +2776,9 @@ def test_reattach_on_restart_via_default_args_reaches_durable(self, dag_maker):
         assert k.durable is False
         assert k.reattach_on_restart is False
 
+    def test_supports_durable_execution_marker(self):
+        assert KubernetesPodOperator.__supports_durable_execution is True

Review Comment:
   Thanks, fixed in 55a6b8ffb3



##########
providers/common/ai/tests/unit/common/ai/operators/test_agent.py:
##########
@@ -759,6 +759,9 @@ def test_cleanup_skipped_when_post_run_step_fails(self, mock_hook_cls, mock_buil
 
         storage.cleanup.assert_not_called()
 
+    def test_supports_durable_execution_marker(self):
+        assert AgentOperator.__supports_durable_execution is True

Review Comment:
   Thanks, fixed in 55a6b8ffb3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org