You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/05/21 11:17:10 UTC

[GitHub] [maven-shade-plugin] kriegaex commented on pull request #95: [MSHADE-391] Do not write modified class files for no-op relocations

kriegaex commented on pull request #95:
URL: https://github.com/apache/maven-shade-plugin/pull/95#issuecomment-845878650


   > I wonder if you could try to add a test case in order to prevent regressions in the future
   
   Such a test would be heuristic, relying on whether ASM happens to restructure certain class files during transformation or not. It would also be an integration test with some real world dependencies and classes using them. Indirectly, we would be testing ASM rather than Shade, but the test is certainly doable. It would be more expensive to create than the actual change, though.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org