WG: WSDoAllReceiver

[Dittmann Werner <we...@siemens.com>]

Forwarded to the list.

Christof, because its your coding, can you please
check the the modifications/patch. If its ok we
can checkin. Thanks.

Regards,
Werner

-----Ursprüngliche Nachricht-----
Von: David Del Vecchio [mailto:ddelvecc@virginia.edu] 
Gesendet: Donnerstag, 24. Juni 2004 06:57
An: Dittmann Werner; Davanum Srinivas
Betreff: WSDoAllReceiver


I've been using WSS4J for a project I'm working it on and encountered a
small problem in the verifyTrust() method of WSDoAllReceiver.java.
There's a loop that looks something like this:

for (int j=0; j < certs.length; j++) {
	cert = certs[i];
	x509certs[certs.length + j] = cert;
}

which seems to crash if certs.length > 1 since x509certs.length is set
to be certs.length + 1. I think it should probably look something like
this instead:

for (int j=0; j < certs.length; j++) {
	cert = certs[j];
	x509certs[j + 1] = cert;
}

Also if verifyTrust is intended as a hook for subclasses, it should
probably be protected rather than private. Anyway, attached should be a
modified version of the file along with a patch. 

David