You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Carl Steinbach (JIRA)" <ji...@apache.org> on 2012/11/06 07:52:12 UTC
[jira] [Created] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Carl Steinbach created HIVE-3676:
------------------------------------
Summary: INSERT INTO regression caused by HIVE-3465
Key: HIVE-3676
URL: https://issues.apache.org/jira/browse/HIVE-3676
Project: Hive
Issue Type: Bug
Components: Query Processor
Reporter: Carl Steinbach
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HIVE-3676:
------------------------------
Attachment: HIVE-3676.D6741.1.patch
navis requested code review of "HIVE-3676 [jira] INSERT INTO regression caused by HIVE-3465".
Reviewers: JIRA
DPAL-1931 INSERT INTO regression caused by HIVE-3465
TEST PLAN
EMPTY
REVISION DETAIL
https://reviews.facebook.net/D6741
AFFECTED FILES
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
ql/src/test/queries/clientpositive/insert1.q
ql/src/test/results/clientpositive/insert1.q.out
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/16017/
To: JIRA, navis
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan resolved HIVE-3676.
------------------------------------
Resolution: Fixed
This is getting taken care of in HIVE-3749
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Mark Grover (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497787#comment-13497787 ]
Mark Grover commented on HIVE-3676:
-----------------------------------
(Non-committer)
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashutosh Chauhan reopened HIVE-3676:
------------------------------------
Carl / Navis,
After this commit ant test -Dtestcase=TestCliDriver -Dqfile=insert1.q is failing consistently on trunk. First failure was reported on https://builds.apache.org/job/Hive-trunk-h0.21/1805/
Can you take a look?
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-3676:
---------------------------------
Resolution: Fixed
Fix Version/s: 0.10.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk. Thanks Navis!
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505069#comment-13505069 ]
Navis commented on HIVE-3676:
-----------------------------
@Ashutosh,
Newly added test case seemed not deterministic. I'll fix this in another issue. Sorry.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497801#comment-13497801 ]
Phabricator commented on HIVE-3676:
-----------------------------------
cwsteinbach has accepted the revision "HIVE-3676 [jira] INSERT INTO regression caused by HIVE-3465".
REVISION DETAIL
https://reviews.facebook.net/D6741
BRANCH
DPAL-1931
To: JIRA, cwsteinbach, navis
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499131#comment-13499131 ]
Phabricator commented on HIVE-3676:
-----------------------------------
navis has closed the revision "HIVE-3676 [jira] INSERT INTO regression caused by HIVE-3465".
Closed by cws.
CHANGED PRIOR TO COMMIT
https://reviews.facebook.net/D6741?vs=21897&id=21963#differential-review-toc
REVISION DETAIL
https://reviews.facebook.net/D6741
COMMIT
https://reviews.facebook.net/rHIVE1410559
To: JIRA, cwsteinbach, navis
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Mark Grover (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497782#comment-13497782 ]
Mark Grover commented on HIVE-3676:
-----------------------------------
Looks good to me.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505344#comment-13505344 ]
Hudson commented on HIVE-3676:
------------------------------
Integrated in Hive-trunk-h0.21 #1821 (See [https://builds.apache.org/job/Hive-trunk-h0.21/1821/])
HIVE-3749 : New test cases added by HIVE-3676 in insert1.q is not deterministic (Navis via Ashutosh Chauhan) (Revision 1414488)
Result = FAILURE
hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1414488
Files :
* /hive/trunk/ql/src/test/queries/clientpositive/insert1.q
* /hive/trunk/ql/src/test/results/clientpositive/insert1.q.out
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13497799#comment-13497799 ]
Carl Steinbach commented on HIVE-3676:
--------------------------------------
+1. Will commit if tests pass.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis updated HIVE-3676:
------------------------
Status: Patch Available (was: Open)
Sorry for inconvenience.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Navis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Navis reassigned HIVE-3676:
---------------------------
Assignee: Navis
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Ashutosh Chauhan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505076#comment-13505076 ]
Ashutosh Chauhan commented on HIVE-3676:
----------------------------------------
Thanks, Navis for taking a look. Yeah, it seems non-deterministic. It passed for me on one machine, but failed on other two. Appreciate your help. If you are going to open a new jira to fix this, feel free to resolve this one.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
> Assignee: Navis
> Fix For: 0.10.0
>
> Attachments: HIVE-3676.D6741.1.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-3676) INSERT INTO regression caused by
HIVE-3465
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-3676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491258#comment-13491258 ]
Carl Steinbach commented on HIVE-3676:
--------------------------------------
Prior to HIVE-3465 the following set of statements produced the expected result:
{noformat}
CREATE DATABASE db2;
USE db2;
CREATE TABLE result(col1 STRING);
INSERT OVERWRITE TABLE result SELECT 'db2_insert1' FROM default.src LIMIT 1;
INSERT INTO TABLE result SELECT 'db2_insert2' FROM default.src LIMIT 1;
SELECT * FROM result;
> db_insert1
> db_insert2
{noformat}
While the following set of statements produced inaccurate results:
{noformat}
CREATE DATABASE db1;
CREATE TABLE db1.result(col1 STRING);
INSERT OVERWRITE TABLE db1.result SELECT 'db1_insert1' FROM src LIMIT 1;
INSERT INTO TABLE db1.result SELECT 'db1_insert2' FROM src LIMIT 1;
SELECT * FROM db1.result;
> db1_insert2
{noformat}
After HIVE-3465 the first set of statements produces inaccurate results, while the second set of statements now behaves as expected.
> INSERT INTO regression caused by HIVE-3465
> ------------------------------------------
>
> Key: HIVE-3676
> URL: https://issues.apache.org/jira/browse/HIVE-3676
> Project: Hive
> Issue Type: Bug
> Components: Query Processor
> Reporter: Carl Steinbach
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira