You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@tsfile.apache.org by "ColinLeeo (via GitHub)" <gi...@apache.org> on 2026/10/17 10:56:39 UTC

[PR] [CPP] Preserve embedded NUL bytes in DICTIONARY strings [tsfile]

ColinLeeo opened a new pull request, #1022:
URL: https://github.com/apache/tsfile/pull/1022

   DICTIONARY decoding in C++ truncated TEXT/STRING values at the first NUL byte because `read_var_str` constructed a C string without its encoded length. Preserve the full byte length, including empty values and embedded/trailing NULs.
   
   Adds a Java-generated binary dictionary golden test, a C++ dictionary round trip, and a var-string regression spanning ByteStream pages.
   
   Validation: 33 byte-stream/dictionary tests passed; C++ Spotless and `git diff --check` passed. This addresses the dictionary failure exposed by #1021 independently of the compatibility-matrix expansion.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CPP] Preserve embedded NUL bytes in DICTIONARY strings [tsfile]

Posted by "ColinLeeo (via GitHub)" <gi...@apache.org>.
ColinLeeo merged PR #1022:
URL: https://github.com/apache/tsfile/pull/1022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@tsfile.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org