You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/09/02 17:20:55 UTC

[GitHub] [superset] Paulo-Eduardo opened a new pull request, #21312: [WIP]fix(cursor-dragging): Changing curso while dragging component on charts page

Paulo-Eduardo opened a new pull request, #21312:
URL: https://github.com/apache/superset/pull/21312

   ### SUMMARY
   So, created a workaround to change cursor to grabbing while dragging
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TESTING INSTRUCTIONS
   - Click Charts in the top nav
   - Open up a chart from the list view
   - Drag an item to check cursor behavior
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #21312: [WIP]fix(cursor-dragging): Changing curso while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239615682

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] stephenLYZ commented on a diff in pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
stephenLYZ commented on code in PR #21312:
URL: https://github.com/apache/superset/pull/21312#discussion_r970361942


##########
superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelDragOption/index.tsx:
##########
@@ -16,7 +16,7 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-import React from 'react';
+import React, { useEffect } from 'react';

Review Comment:
   Remove no used import will fix lint.



##########
superset-frontend/src/explore/components/DatasourcePanel/DatasourcePanelDragOption/index.tsx:
##########
@@ -80,7 +80,11 @@ export default function DatasourcePanelDragOption(
   };
 
   return (
-    <DatasourceItemContainer data-test="DatasourcePanelDragOption" ref={drag}>
+    <DatasourceItemContainer

Review Comment:
   We can use `styled-component` property instead of inline style. Like this:
   
   ```jsx
   <DatasourceItemContainer isDragging={isDragging} data-test="DatasourcePanelDragOption" ref={drag} />
   
   const DatasourceItemContainer = styled.div`
     ${({ theme, isDragging }) => css`
       cursor: ${isDragging ? 'grabbing': 'pointer'};
       ...
     `}
   `;
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] rusackas commented on pull request #21312: [WIP]fix(cursor-dragging): Changing curso while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239740205

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239777714

   @rusackas Ephemeral environment creation failed. Please check the Actions logs for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239751186

   @rusackas Ephemeral environment creation failed. Please check the Actions logs for details.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #21312: [WIP]fix(cursor-dragging): Changing curso while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239556355

   @Paulo-Eduardo Ephemeral environment creation is currently limited to committers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [PR] [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page
URL: https://github.com/apache/superset/pull/21312


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] Paulo-Eduardo commented on pull request #21312: [WIP]fix(cursor-dragging): Changing curso while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
Paulo-Eduardo commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239474479

   /testenv up


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239751156

   @rusackas Container image not yet published for this PR. Please try again when build is complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [superset] github-actions[bot] commented on pull request #21312: [WIP]fix(cursor-dragging): Changing cursor while dragging component on charts page

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21312:
URL: https://github.com/apache/superset/pull/21312#issuecomment-1239777698

   @rusackas Container image not yet published for this PR. Please try again when build is complete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org