You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "VVKot (via GitHub)" <gi...@apache.org> on 2023/08/07 08:18:21 UTC

[GitHub] [spark] VVKot commented on a diff in pull request #42297: [SPARK-44609][KUBERNETES] Remove executor pod from PodsAllocator if it was removed from scheduler backend

VVKot commented on code in PR #42297:
URL: https://github.com/apache/spark/pull/42297#discussion_r1285536878


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocator.scala:
##########
@@ -190,6 +190,13 @@ class ExecutorPodsAllocator(
       newlyCreatedExecutors.filterKeys(schedulerKnownExecs.contains(_)).mapValues(_._1)
     newlyCreatedExecutors --= schedulerKnownNewlyCreatedExecs.keySet
 
+    // If executor was created and removed in a short period, then it is possible that the creation

Review Comment:
   @dongjoon-hyun this is happening when underlying node is decommissioned in Kubernetes. If that happens shortly after executor is scheduled on that node, we hit the bug in question.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org