You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/07/28 16:01:15 UTC
Review Request 61220: Added MESOS-5116 to the CHANGELOG.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/
-----------------------------------------------------------
Review request for mesos and Jiang Yan Xu.
Repository: mesos
Description
-------
Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
the CHANGELOG.
Diffs
-----
CHANGELOG 84590ed6c5d7f90b27862e734df9297e0906e043
Diff: https://reviews.apache.org/r/61220/diff/1/
Testing
-------
None.
Thanks,
James Peach
Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/#review181722
-----------------------------------------------------------
Can we also add it to upgrades.md? It's not a new flag but the flag can now be used more widely?
CHANGELOG
Lines 17 (patched)
<https://reviews.apache.org/r/61220/#comment257373>
The flag is `--no-enforce_container_disk_quota`.
- Jiang Yan Xu
On July 28, 2017, 9:01 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61220/
> -----------------------------------------------------------
>
> (Updated July 28, 2017, 9:01 a.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
> the CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG 84590ed6c5d7f90b27862e734df9297e0906e043
>
>
> Diff: https://reviews.apache.org/r/61220/diff/1/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/#review182877
-----------------------------------------------------------
Patch looks great!
Reviews applied: [61220]
Passed command: support\windows-build.bat
- Mesos Reviewbot Windows
On Aug. 14, 2017, 3:45 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61220/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2017, 3:45 p.m.)
>
>
> Review request for mesos, Kapil Arya and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
> the CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG abb0e3bea95648b91605cec37b21f079d2b15b41
> docs/configuration.md 6ab2d1a06de9e4fff9e6769d2b2cbd05e8f3d17a
> docs/upgrades.md 349d8a144097d9be354a95c904ab7209ae3cc442
>
>
> Diff: https://reviews.apache.org/r/61220/diff/3/
>
>
> Testing
> -------
>
> Generated website and verified correct links and content.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/
-----------------------------------------------------------
(Updated Aug. 14, 2017, 3:45 p.m.)
Review request for mesos, Kapil Arya and Jiang Yan Xu.
Repository: mesos
Description
-------
Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
the CHANGELOG.
Diffs (updated)
-----
CHANGELOG abb0e3bea95648b91605cec37b21f079d2b15b41
docs/configuration.md 6ab2d1a06de9e4fff9e6769d2b2cbd05e8f3d17a
docs/upgrades.md 349d8a144097d9be354a95c904ab7209ae3cc442
Diff: https://reviews.apache.org/r/61220/diff/3/
Changes: https://reviews.apache.org/r/61220/diff/2-3/
Testing (updated)
-------
Generated website and verified correct links and content.
Thanks,
James Peach
Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/#review181860
-----------------------------------------------------------
Fix it, then Ship it!
docs/upgrades.md
Lines 350 (patched)
<https://reviews.apache.org/r/61220/#comment257638>
Remove the `#`. This is why we also need "Testing Done" for doc changes. :) Normally we just say "Tested with a markdown viewer".
- Jiang Yan Xu
On July 31, 2017, 2:42 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61220/
> -----------------------------------------------------------
>
> (Updated July 31, 2017, 2:42 p.m.)
>
>
> Review request for mesos and Jiang Yan Xu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
> the CHANGELOG.
>
>
> Diffs
> -----
>
> CHANGELOG e091fec10296090123986ca44a86645e5867aa0d
> docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d
> docs/upgrades.md 349d8a144097d9be354a95c904ab7209ae3cc442
>
>
> Diff: https://reviews.apache.org/r/61220/diff/2/
>
>
> Testing
> -------
>
> None.
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 61220: Added MESOS-5116 to the CHANGELOG.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61220/
-----------------------------------------------------------
(Updated July 31, 2017, 9:42 p.m.)
Review request for mesos and Jiang Yan Xu.
Repository: mesos
Description
-------
Added MESOS-5116 (XFS disk isolator support for no-enforce mode) to
the CHANGELOG.
Diffs (updated)
-----
CHANGELOG e091fec10296090123986ca44a86645e5867aa0d
docs/configuration.md a06ac82e7b908601b9ba97011931276e6292102d
docs/upgrades.md 349d8a144097d9be354a95c904ab7209ae3cc442
Diff: https://reviews.apache.org/r/61220/diff/2/
Changes: https://reviews.apache.org/r/61220/diff/1-2/
Testing
-------
None.
Thanks,
James Peach