You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/12/18 20:26:25 UTC

[PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

jscheffl opened a new pull request, #45057:
URL: https://github.com/apache/airflow/pull/45057

   Reverts apache/airflow#44744
   
   Seems to be the "quickest" way to fix main, will re-open a PR to merge back again with full tests after
   
   FYI @vincbeck 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #45057:
URL: https://github.com/apache/airflow/pull/45057#issuecomment-2552221997

   Note: I#ll have another PR as fix in 5min, maybe that saves a reversion...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #45057:
URL: https://github.com/apache/airflow/pull/45057#issuecomment-2552248656

   Yep.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl merged PR #45057:
URL: https://github.com/apache/airflow/pull/45057


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #45057:
URL: https://github.com/apache/airflow/pull/45057#issuecomment-2552265811

   Other PR as quick fix failed, so I change my opinion and would propose the reversion route. Then we can re-apply and check fully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Revert "AIP-79 Generate assets for Flask application in FAB provider" [airflow]

Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #45057:
URL: https://github.com/apache/airflow/pull/45057#issuecomment-2552230945

   I propose to close this in favor of #45058


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org