You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by restouffer <gi...@git.apache.org> on 2016/02/24 20:33:07 UTC
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
GitHub user restouffer opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126
[Android] Handle redirects when downloading a file
The FileTransfer plugin was stopping on a 301 redirect and storing the HTML from that page instead of the target file. This adds a loop that detects redirect headers and continues following them until a non-redirect page is loaded.
Based on the work of mathieudutour: https://github.com/phonegap/phonegap-plugin-contentsync/pull/95
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/restouffer/cordova-plugin-file-transfer patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-file-transfer/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit 0b9232a6db7c47e71140db6f7a6eac3ce3773c32
Author: restouffer <re...@gmail.com>
Date: 2016-02-24T19:27:52Z
Handle URL redirects when downloading a file
Based on the work of mathieudutour: https://github.com/phonegap/phonegap-plugin-contentsync/pull/95
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Posted by MIYankov <gi...@git.apache.org>.
Github user MIYankov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-219403560
I encountered the same problem. restouffer's branch fixes the issue. It's vital that this gets merged soon since usually we don't have power over the backend to remove the redirect.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Posted by restouffer <gi...@git.apache.org>.
Github user restouffer commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-220013558
I'm not familiar with Jenkins, but I'm not convinced those links suggest this patch is the cause of the CI failures. This patch is [Build #10](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10/) out of 11. Build 9 has 75 failures while 10 has 59, which could mean this patch fixes 16 errors from the earlier builds. If there is a problem with the patch I would be more than happy to try fixing it, but I'll need more details.
[According to Jenkins:](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/)
```
Build Errors
#1 0
#2 0
#3 0
#4 72
#5 75
#6 77
#7 77
#8 77
#9 75
#10 59
#11 77
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redirects when d...
Posted by Pazkov <gi...@git.apache.org>.
Github user Pazkov commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126
Please merge...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Posted by abarranco <gi...@git.apache.org>.
Github user abarranco commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-197310054
I've been 2 days debugging my project when i figured out that this was actually a problem. When i tried to download images from http with 301 response, file transfer downloaded that response and not followed the new url to get the final resource via https. Exactly what restouffer says. I think the plugin should allow to download the real resource. I am thinking this could be a security issue as well??. The url suggested in the 301 response will go trought the whitelist plugin?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Posted by ghenry22 <gi...@git.apache.org>.
Github user ghenry22 commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-199633964
I have also hit this problem and it causes ongoing issues for my app. Could this be checked and merged soon?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-file-transfer pull request: [Android] Handle redire...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/126#issuecomment-219934546
Cordova CI Build has one or more failures.
**Commit** - [Link](https://github.com/apache/cordova-plugin-file-transfer/pull/126/commits/0b9232a6db7c47e71140db6f7a6eac3ce3773c32)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-store/artifact/) |
| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=windows-slave,platformName=windows-8.1-phone/artifact/) |
| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=ios/artifact/) |
| [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/10//label=mac-slave,platformName=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org