You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/03/26 23:56:25 UTC
[jira] [Commented] (CB-10965) xml helper allows multiple instances
of name under same parent config.xml
[ https://issues.apache.org/jira/browse/CB-10965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15213233#comment-15213233 ]
ASF GitHub Bot commented on CB-10965:
-------------------------------------
GitHub user csantanapr opened a pull request:
https://github.com/apache/cordova-lib/pull/417
CB-10965 xml helper allows multiple instances to be merge in config.xml
@vladimir-kotikov I this is the real fix on duplicate names ending up in final config.xml triggering the unwanted rename of the xcode project in ios
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/csantanapr/cordova-lib CB-10965
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/417.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #417
----
commit 4577f3e61693db8ac531917ed4a273f4de40b903
Author: Carlos Santana <cs...@gmail.com>
Date: 2016-03-26T22:53:52Z
CB-10965 xml helper allows multiple instances to be merge in config.xml
----
> xml helper allows multiple instances of name under same parent config.xml
> -------------------------------------------------------------------------
>
> Key: CB-10965
> URL: https://issues.apache.org/jira/browse/CB-10965
> Project: Apache Cordova
> Issue Type: Bug
> Components: CLI
> Affects Versions: Master
> Reporter: Carlos Santana
> Priority: Minor
> Labels: common
>
> This some what related to CB-10961
> Create new app
> Add multiple name tags in toplevel config.xml
> <name>app1</name>
> <name>app2</name>
> <platform name="ios">
> <name>app3</name>
> </platform>
> cordova platform add ios
> cordova prepare
> Open platforms/ios/app3/config.xml
> There are multiple instances of name at top level
> <name>app3</name>
> <name>app1</name>
> <name>app2</name>
> The mergeXml function should be updated to avoid this and only allow one final name tag added to top level dest.
> https://github.com/apache/cordova-lib/blob/master/cordova-common/src/util/xml-helpers.js#L198
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org