You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/03/11 11:40:26 UTC

[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1468: Implement FlatMap insert(const std::pair& kv)

wwbmmm commented on a change in pull request #1468:
URL: https://github.com/apache/incubator-brpc/pull/1468#discussion_r824636158



##########
File path: test/flat_map_unittest.cpp
##########
@@ -287,10 +287,13 @@ TEST_F(FlatMapTest, make_sure_all_methods_compile) {
     ASSERT_EQ(20, m1[2]);
     ASSERT_EQ(2u, m1.size());
     m1.insert(1, 100);
+    m1.insert(3, 30);

Review comment:
       这个case是不是没覆盖到新加的函数?
   是不是改成 insert({3, 30})




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org