You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/12/02 23:08:29 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2835: GOBBLIN-989: Track and report record level SLA in Gobblin Kafka Extra…

sv2000 commented on a change in pull request #2835: GOBBLIN-989: Track and report record level SLA in Gobblin Kafka Extra…
URL: https://github.com/apache/incubator-gobblin/pull/2835#discussion_r352908232
 
 

 ##########
 File path: gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaSource.java
 ##########
 @@ -371,6 +372,10 @@ private void createEmptyWorkUnitsForSkippedPartitions(Map<String, List<WorkUnit>
         if (!topicQualified) {
           skipWorkUnit(workUnit);
         }
+        //Copy the SLA config from SourceState to WorkUnitState.
+        if (state.contains(KafkaSource.RECORD_LEVEL_SLA_MINUTES_KEY)) {
 
 Review comment:
   Created a separate method for copying properties from SourceState to WorkunitState and added a call to this method in getWorkUnitForTopicPartition.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services