[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #7461: [IOTDB-4545] Seperate ratis configs for data/schema/partition region

[GitBox <gi...@apache.org>]

CRZbulabula commented on code in PR #7461:
URL: https://github.com/apache/iotdb/pull/7461#discussion_r982009486


##########
thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -49,13 +49,26 @@ struct TGlobalConfig {
 }
 
 struct TRatisConfig {
-  1: optional i64 appenderBufferSize
-  2: optional i64 snapshotTriggerThreshold
-  3: optional bool logUnsafeFlushEnable
-  4: optional i64 logSegmentSizeMax
-  5: optional i64 grpcFlowControlWindow
-  6: optional i64 leaderElectionTimeoutMin
-  7: optional i64 leaderElectionTimeoutMax
+  1: optional i64 schemaAppenderBufferSize
+  2: optional i64 dataAppenderBufferSize
+
+  3: optional i64 schemaSnapshotTriggerThreshold
+  4: optional i64 dataSnapshotTriggerThreshold
+
+  5: optional bool schemaLogUnsafeFlushEnable
+  6: optional bool dataLogUnsafeFlushEnable
+
+  7: optional i64 schemaLogSegmentSizeMax
+  8: optional i64 dataLogSegmentSizeMax
+
+  9: optional i64 schemaGrpcFlowControlWindow
+  10: optional i64 dataGrpcFlowControlWindow
+
+  11: optional i64 schemaLeaderElectionTimeoutMin
+  12: optional i64 dataLeaderElectionTimeoutMin
+
+  13: optional i64 schemaLeaderElectionTimeoutMax
+  14: optional i64 dataLeaderElectionTimeoutMax

Review Comment:
   required is better? Since the ratis configurations are always assigned by ConfigNode.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org