You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Bears0haunt (via GitHub)" <gi...@apache.org> on 2023/12/05 10:17:11 UTC
[PR] [chore](log) change some meaningless log to vlog [doris]
Bears0haunt opened a new pull request, #28023:
URL: https://github.com/apache/doris/pull/28023
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1845284999
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "Bears0haunt (via GitHub)" <gi...@apache.org>.
Bears0haunt commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1840474863
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1840553343
(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 43.72 seconds
stream load tsv: 577 seconds loaded 74807831229 Bytes, about 123 MB/s
stream load json: 18 seconds loaded 2358488459 Bytes, about 124 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 28.7 seconds inserted 10000000 Rows, about 348K ops/s
storage size: 17164516411 Bytes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1840649709
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 251fc0efef0040de7f7f43555fc6e190d422e3df, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4656 4479 4473 4473
q2 360 167 158 158
q3 1470 1248 1200 1200
q4 1094 923 887 887
q5 3177 3196 3184 3184
q6 244 129 126 126
q7 1009 503 502 502
q8 2200 2233 2195 2195
q9 6987 6809 6666 6666
q10 3203 3260 3270 3260
q11 328 216 213 213
q12 358 212 212 212
q13 4569 3838 4703 3838
q14 241 216 221 216
q15 563 529 524 524
q16 434 381 388 381
q17 1009 606 555 555
q18 7694 7916 6903 6903
q19 1512 1407 1387 1387
q20 533 335 326 326
q21 3064 2655 2679 2655
q22 353 285 291 285
Total cold run time: 45058 ms
Total hot run time: 40146 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4419 4384 4376 4376
q2 268 168 179 168
q3 3537 3527 3510 3510
q4 2385 2373 2366 2366
q5 5745 5750 5747 5747
q6 238 121 121 121
q7 2390 1847 1862 1847
q8 3521 3519 3514 3514
q9 9046 9016 9004 9004
q10 3917 3982 4006 3982
q11 512 394 386 386
q12 760 620 584 584
q13 4285 3596 3579 3579
q14 279 241 247 241
q15 574 529 525 525
q16 504 473 441 441
q17 1849 1816 1847 1816
q18 8694 8166 8274 8166
q19 1738 1719 1740 1719
q20 2277 1955 1965 1955
q21 6550 6147 6173 6147
q22 508 415 422 415
Total cold run time: 63996 ms
Total hot run time: 60609 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843111349
<details>
<summary>TPC-H test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'</summary>
```
Tpch sf100 test result on commit 24d01454a151238e86dd1682b2379cebc93d90a9, data reload: false
run tpch-sf100 query with default conf and session variables
q1 4747 4461 4440 4440
q2 361 156 153 153
q3 1474 1241 1216 1216
q4 1118 945 881 881
q5 3182 3139 3189 3139
q6 251 131 128 128
q7 982 495 477 477
q8 2227 2216 2199 2199
q9 6709 6707 6664 6664
q10 3234 3235 3271 3235
q11 334 201 199 199
q12 352 211 214 211
q13 4547 3800 3793 3793
q14 240 207 216 207
q15 564 514 529 514
q16 447 390 388 388
q17 1004 603 615 603
q18 7465 7454 7142 7142
q19 1521 1418 1414 1414
q20 520 355 331 331
q21 3119 2704 2695 2695
q22 358 297 305 297
Total cold run time: 44756 ms
Total hot run time: 40326 ms
run tpch-sf100 query with default conf and set session variable runtime_filter_mode=off
q1 4422 4395 4375 4375
q2 265 161 176 161
q3 3538 3532 3529 3529
q4 2393 2385 2380 2380
q5 5746 5734 5782 5734
q6 241 117 122 117
q7 2385 1863 1869 1863
q8 3512 3511 3543 3511
q9 9077 9050 9038 9038
q10 3934 4014 4014 4014
q11 502 372 372 372
q12 778 599 600 599
q13 4296 3584 3552 3552
q14 291 250 259 250
q15 571 518 519 518
q16 508 476 454 454
q17 1887 1830 1862 1830
q18 8705 8275 8149 8149
q19 1714 1734 1760 1734
q20 2276 1963 1955 1955
q21 6526 6206 6174 6174
q22 507 422 418 418
Total cold run time: 64074 ms
Total hot run time: 60727 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #28023:
URL: https://github.com/apache/doris/pull/28023#discussion_r1418421934
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -959,10 +959,15 @@ Status TabletManager::load_tablet_from_dir(DataDir* store, TTabletId tablet_id,
tablet_meta->set_tablet_uid(std::move(tablet_uid));
std::string meta_binary;
RETURN_IF_ERROR(tablet_meta->serialize(&meta_binary));
- RETURN_NOT_OK_STATUS_WITH_WARN(
- load_tablet_from_meta(store, tablet_id, schema_hash, meta_binary, true, force, restore,
- true),
- strings::Substitute("fail to load tablet. header_path=$0", header_path));
+ Status load_tablet_from_meta_status = load_tablet_from_meta(
+ store, tablet_id, schema_hash, meta_binary, true, force, restore, true);
+ if (load_tablet_from_meta_status.is<TABLE_ALREADY_DELETED_ERROR>()) {
+ VLOG_NOTICE << load_tablet_from_meta_status;
+ } else {
+ LOG(WARNING) << fmt::format("fail to load tablet. header_path=$0", header_path)
Review Comment:
```suggestion
LOG(WARNING) << "fail to load tablet. header_path=" << header_path
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843068607
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "Bears0haunt (via GitHub)" <gi...@apache.org>.
Bears0haunt closed pull request #28023: [chore](log) change some meaningless log to vlog
URL: https://github.com/apache/doris/pull/28023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1845303405
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "Bears0haunt (via GitHub)" <gi...@apache.org>.
Bears0haunt commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843001324
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "Bears0haunt (via GitHub)" <gi...@apache.org>.
Bears0haunt commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1842986240
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843069944
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843071565
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843069874
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "platoneko (via GitHub)" <gi...@apache.org>.
platoneko commented on code in PR #28023:
URL: https://github.com/apache/doris/pull/28023#discussion_r1417149338
##########
be/src/olap/tablet_manager.cpp:
##########
@@ -959,10 +960,15 @@ Status TabletManager::load_tablet_from_dir(DataDir* store, TTabletId tablet_id,
tablet_meta->set_tablet_uid(std::move(tablet_uid));
std::string meta_binary;
RETURN_IF_ERROR(tablet_meta->serialize(&meta_binary));
- RETURN_NOT_OK_STATUS_WITH_WARN(
- load_tablet_from_meta(store, tablet_id, schema_hash, meta_binary, true, force, restore,
- true),
- strings::Substitute("fail to load tablet. header_path=$0", header_path));
+ Status load_tablet_from_meta_status = load_tablet_from_meta(
+ store, tablet_id, schema_hash, meta_binary, true, force, restore, true);
+ if (load_tablet_from_meta_status.is<TABLE_ALREADY_DELETED_ERROR>()) {
+ VLOG_NOTICE << load_tablet_from_meta_status;
+ } else {
+ RETURN_NOT_OK_STATUS_WITH_WARN(
+ load_tablet_from_meta_status,
+ strings::Substitute("fail to load tablet. header_path=$0", header_path));
Review Comment:
Use `fmt::format` instead of `strings::Substitute`. DON'T use `RETURN_NOT_OK_STATUS_WITH_WARN` because this will result in an unnecessary copy (`Status _s = (stmt);`), use `LOG(WARNING)` directly in non-ok branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "Bears0haunt (via GitHub)" <gi...@apache.org>.
Bears0haunt commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1843036141
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [chore](log) change some meaningless log to vlog [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28023:
URL: https://github.com/apache/doris/pull/28023#issuecomment-1840460542
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org