You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2024/02/23 11:34:55 UTC
[PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
kou opened a new pull request, #40210:
URL: https://github.com/apache/arrow/pull/40210
### Rationale for this change
Because upstream uses "RapidJSON" for CMake target name.
### What changes are included in this PR?
Rename "rapidjson::rapidjson" to "RapidJSON".
FindRapidJSONAlt.cmake provides "RapidJSON" CMake target instead of just providing RAPIDJSON_INCLUDE_DIR.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40210:
URL: https://github.com/apache/arrow/pull/40210#issuecomment-1962225727
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #40210:
URL: https://github.com/apache/arrow/pull/40210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #40210:
URL: https://github.com/apache/arrow/pull/40210#issuecomment-1961171602
@github-actions crossbow submit -g cpp -g r -g linux -g python -g r
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #40210:
URL: https://github.com/apache/arrow/pull/40210#issuecomment-1962266060
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 193e39cad4d8e1a01376d6b5199077e401484838.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/21933954293) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40210:
URL: https://github.com/apache/arrow/pull/40210#issuecomment-1961171342
:warning: GitHub issue #40209 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-40209: [C++][CMake] Use "RapidJSON" CMake target for RapidJSON [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40210:
URL: https://github.com/apache/arrow/pull/40210#issuecomment-1961177168
Revision: 7fc89185e3be8fc49e35ce92618cdc8320a9257c
Submitted crossbow builds: [ursacomputing/crossbow @ actions-3a9e894030](https://github.com/ursacomputing/crossbow/branches/all?query=actions-3a9e894030)
|Task|Status|
|----|------|
|almalinux-8-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623939/job/21904880725)|
|almalinux-8-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623955/job/21904881618)|
|almalinux-9-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624053/job/21904881690)|
|almalinux-9-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624367/job/21904883522)|
|amazon-linux-2023-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624641/job/21904910570)|
|amazon-linux-2023-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623644/job/21904878678)|
|centos-7-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624179/job/21904882634)|
|centos-8-stream-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624275/job/21904883357)|
|centos-8-stream-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624299/job/21904882806)|
|centos-9-stream-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623889/job/21904880711)|
|centos-9-stream-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623786/job/21904880056)|
|debian-bookworm-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624180/job/21904883325)|
|debian-bookworm-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623449/job/21904877750)|
|debian-bullseye-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624378/job/21904883618)|
|debian-bullseye-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623615/job/21904878539)|
|debian-trixie-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624550/job/21904910119)|
|debian-trixie-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623375/job/21904877275)|
|r-binary-packages|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624581/job/21904926906)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623006/job/21904875724)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623705/job/21904878683)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623178/job/21904876390)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/runs/21904882394)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624428/job/21904909865)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624130/job/21904881865)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624213/job/21904883317)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624413/job/21904884222)|
|test-conda-python-3.10-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623819/job/21904880512)|
|test-conda-python-3.10-pandas-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623081/job/21904875995)|
|test-conda-python-3.10-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624148/job/21904881940)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624145/job/21904881968)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623347/job/21904877100)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623418/job/21904877286)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623978/job/21904881637)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624096/job/21904881793)|
|test-conda-python-3.11-pandas-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623002/job/21904875738)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623331/job/21904876755)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624462/job/21904909870)|
|test-conda-python-3.8|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624622/job/21904910353)|
|test-conda-python-3.8-pandas-1.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623194/job/21904876392)|
|test-conda-python-3.8-spark-v3.5.0|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624196/job/21904882740)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623442/job/21904877289)|
|test-conda-python-3.9-pandas-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624200/job/21904883341)|
|test-cuda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624607/job/21904910108)|
|test-cuda-python|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623628/job/21904878511)|
|test-debian-11-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624665/job/21904910578)|
|test-debian-11-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623352/job/21904877096)|
|test-debian-11-python-3-amd64|[](https://github.com/ursacomputing/crossbow/runs/21904879111)|
|test-debian-11-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624539/job/21904910007)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623630/job/21904878508)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/runs/21904882737)|
|test-fedora-r-clang-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/21904880617)|
|test-r-arrow-backwards-compatibility|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624569/job/21904910208)|
|test-r-depsource-bundled|[](https://github.com/ursacomputing/crossbow/runs/21904879524)|
|test-r-depsource-system|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623781/job/21904880094)|
|test-r-dev-duckdb|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623870/job/21904880532)|
|test-r-devdocs|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623823/job/21904881498)|
|test-r-gcc-11|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624176/job/21904882033)|
|test-r-gcc-12|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624613/job/21904910388)|
|test-r-install-local|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623451/job/21904878351)|
|test-r-install-local-minsizerel|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623882/job/21904881518)|
|test-r-library-r-base-latest|[](https://github.com/ursacomputing/crossbow/runs/21904879098)|
|test-r-linux-as-cran|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623539/job/21904880479)|
|test-r-linux-rchk|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623752/job/21904879299)|
|test-r-linux-valgrind|[](https://github.com/ursacomputing/crossbow/runs/21904881996)|
|test-r-minimal-build|[](https://github.com/ursacomputing/crossbow/runs/21904881474)|
|test-r-offline-maximal|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624000/job/21904950589)|
|test-r-offline-minimal|[](https://github.com/ursacomputing/crossbow/runs/21904879074)|
|test-r-rhub-debian-gcc-devel-lto-latest|[](https://github.com/ursacomputing/crossbow/runs/21904878622)|
|test-r-rhub-debian-gcc-release-custom-ccache|[](https://github.com/ursacomputing/crossbow/runs/21904879517)|
|test-r-rhub-ubuntu-gcc-release-latest|[](https://github.com/ursacomputing/crossbow/runs/21904880590)|
|test-r-rstudio-r-base-4.1-opensuse153|[](https://github.com/ursacomputing/crossbow/runs/21904878121)|
|test-r-rstudio-r-base-4.2-centos7-devtoolset-8|[](https://github.com/ursacomputing/crossbow/runs/21904879713)|
|test-r-rstudio-r-base-4.2-focal|[](https://github.com/ursacomputing/crossbow/runs/21904883156)|
|test-r-ubuntu-22.04|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624358/job/21904884200)|
|test-r-versions|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624243/job/21904884226)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624359/job/21904883498)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623358/job/21904877095)|
|test-ubuntu-20.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623923/job/21904880726)|
|test-ubuntu-20.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624224/job/21904882773)|
|test-ubuntu-20.04-python-3|[](https://github.com/ursacomputing/crossbow/runs/21904880140)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623173/job/21904876288)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624071/job/21904881778)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624605/job/21904910307)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623124/job/21904876300)|
|test-ubuntu-r-sanitizer|[](https://github.com/ursacomputing/crossbow/runs/21904881128)|
|ubuntu-focal-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624132/job/21904881864)|
|ubuntu-focal-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623317/job/21904876843)|
|ubuntu-jammy-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018624354/job/21904883496)|
|ubuntu-jammy-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623641/job/21904878559)|
|ubuntu-noble-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623060/job/21904875988)|
|ubuntu-noble-arm64|[](https://github.com/ursacomputing/crossbow/actions/runs/8018623366/job/21904877103)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org