[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31905: [SPARK-34806][SQL] Add Observation helper for Dataset.observe

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31905:
URL: https://github.com/apache/spark/pull/31905#discussion_r672378395



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -1947,6 +1947,31 @@ class Dataset[T] private[sql](
     CollectMetrics(name, (expr +: exprs).map(_.named), logicalPlan)
   }
 
+  /**
+   * Observe (named) metrics through an [[org.apache.spark.sql.Observation]] instance.

Review comment:
       Yes, another PR would be cleaner. You can put the link of new PR here, @EnricoMi .




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org