[jira] [Commented] (OFBIZ-10577) New Feature: Inventory Cycle Count

["Jacques Le Roux (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17611862#comment-17611862 ] 

Jacques Le Roux commented on OFBIZ-10577:
-----------------------------------------

Hi Yashwant,

I'm beginning to review and must say I don't get things easily.

First, as it's backend, I'd have preferred that new screens would have been totally done with widget forms. Notably with widget forms we don't show find results by default, to prevent waiting when not wanted (much results to grab from DB). Also we don't show the pagination if not needed, too late anyway...

The status field in Find Session screen shows nothing by default. Looking at FindCycleCount.ftl, I guess it's normal when nothing has been done yet, right? Then, as I think it's not obvious, we should show something explaining that, like "No sessions created, nothing to show yet."

On Pawan's #1, you answered:
bq. I see that the checkbox issue is at the framework level It also broken on other screens as well so you can create a new ticket for that.
For me it's working? I mean I can select/deselect all with the checkbox in title line? So what is this checkbox issue? In what screens can we reproduce?

bq. #3: Find InventoryItem Lookup is not working (Attached screenshot for more details)
I see no Find InventoryItem Lookup, still of actuality?

Last but not least question: how do you create sessions? I selected one or all lines, clicked on the Create session button, nothing happens. I mean I can't find any in Find Session or Review Session screens. What could I miss?

In Cycle Count screen, we always see "Page 1 of 8" when it's actually only one page. I think it's not related to your code, please confirm.

OK enough for today, TIA for your answers.

> New Feature: Inventory Cycle Count
> ----------------------------------
>
>                 Key: OFBIZ-10577
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10577
>             Project: OFBiz
>          Issue Type: New Feature
>          Components: hhfacility, product
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: Yashwant Dhakad
>            Assignee: Yashwant Dhakad
>            Priority: Major
>              Labels: audit, inventory
>         Attachments: Checkbox Issue.png, FindSessionIssue.png, InventoryItemLookup.png, ItemSubSeqId.png, Menu Error.png, Menu Error.png, OFBIZ-10577-Database-Changes.patch, OFBIZ-10577.patch, Ui Issue.png, Ui Issue.png, screenshot-1-find-session.png, screenshot-2-pending-locations.png, screenshot-3-add-location-to-session.png, screenshot-4-list-of-review-session.png, screenshot-5-review-session-detail.png, screenshot-6-accept-session.png, screenshot-7-complete-review.png, screenshot-8-report-screen.png
>
>
> *Here are the design notes for cycle count workflow:*
> *Find Session Screen:* In this screen, we will show all the sessions created in the system with respect to the facility, locations, inventory count item, current status, and created date. We have a search field to filter the records on the basis of the facility, status.
> *Find Pending Locations:* In this screen, we have a table listing all the pending locations whose countings are pending and we can create a session for them. All details regarding the pending locations are listed here with the location, next count date, last count date and days extended for the count, total inventory item and product for this location. We have facets for filtering the records on the basis of the facility, not scanned since and scheduled for next scan. Also, we have a global search at the top of the screen. In Pending Locations screen, we have a Create Session button. To create a session we can either select one or more records from the below list or create a new session by yourself.
> In Create Session screen, the basic overview is shown in the "Overview" section and the items are listed in the "Items" section. We can create a new line item by clicking on the 'Add' button and we can also update the item quantity. After completing this, we can proceed with this session and mark it with 'Pending for Review' status from the 'Status' button at the top of the screen or we can simply 'Reject'. 'Reject' status button is available at the top of the screen.
> *Find Review Screen:* In this screen, we have a table listing all the locations pending for the review. All the details regarding the review sessions are listed with the facility, locations and counted inventory item. We have facets for filtering records on the basis of the facility. By clicking any session we can go to its detail screen, where basic details regarding this session are listed in the 'Overview' section and items are listed in the 'Items' section. We can select any number of rows and mark them as 'Accept' or 'Reject'. When these items are marked as 'Accepted' then the variance is created and these are added in the Count Progress report. Only authorized persons can accept or reject the sessions and once the session is accepted it is marked as 'Completed'.
> *Count Progress Report:* In this screen, User can view the advanced counting related analytics with respect to all the 'Completed' status session from Reports Screen. We can filter the records on the basis of the facility and within the date range. We can also see the percentage of the total locations, inventory items counted and errors occurred during the process. Item variance details are listed in the below section in tabular form.
> Following changes to the existing data model to support end to end counting process flow:
> *New entities:*
> *InventoryCount*
>    inventoryCountId
>    uploadedByUserLogin
>    facilityId
>    statusId
>    createdDatetime
>  *InventoryCountItem*
>    inventoryCountId
>    inventoryCountItemSeqId
>    inventoryItemId
>    itemStatusId
>    locationSeqId
>    productId
>    productIdentifier
>    quantity
>  *InventoryCountVariance* 
>    inventoryCountId
>    inventoryCountItemSeqId
>    inventoryItemId
>    productId
>    productIdentifier
>    locationSeqId
>    systemQuantityOnHand
>    actualQuantityOnHand
>    varianceQuantityOnHand
>    totalCost
>    actualCost
>    costVariance
>    actualValue
>    totalValue
>    valueVariance
>    unitCost
>  ***Extended entity:*
>  *FacilityLocation*
>    locked
>    lastCountDate
>    nextCountDate
> **We will prevent the following inbound and outbound transactions within the application if the location is locked for counting:
>  Inventory Transfer 
>  Issuance against Sales Order 
>  Sales Return receiving 
>  Inventory receive 
>  Issuance and return inventory in manufacturing Job
>  Kit breakup 
>  Update Location 
>  Physical Variance creation
> The locked locations won’t have any bearing on the transactions that are affecting the only ATP of parts i.e. Reserving component for Jobs/Sales Orders etc. as they don’t affect QOH in any way.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)