You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2022/11/02 19:13:35 UTC
[GitHub] [incubator-mxnet] josephevans opened a new pull request, #21148: [v1.9.x] TLP Updates
josephevans opened a new pull request, #21148:
URL: https://github.com/apache/incubator-mxnet/pull/21148
Update the v1.9.x branch (which is the current default website) with updates required as a TLP.
- Update all references to `incubator-mxnet` to `mxnet`
- Update website and docs to reflect graduation
- Remove DISCLAIMER
- Update CICD references
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] ChaiBapchya commented on a diff in pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on code in PR #21148:
URL: https://github.com/apache/mxnet/pull/21148#discussion_r1025529267
##########
ci/docker/install/ubuntu_tutorials.sh:
##########
@@ -24,5 +24,9 @@ set -ex
apt-get update || true
apt-get install graphviz
-# sckit-learn past version 0.20 does not support python version 2 and 3.4
-pip3 install jupyter matplotlib Pillow opencv-python scikit-learn graphviz==0.8.4 tqdm mxboard scipy gluoncv
+pip3 install graphviz==0.8.4 tqdm mxboard
+pip3 install jupyter
+pip3 install matplotlib Pillow opencv-python
+pip3 install scipy gluoncv
+pip3 install scikit-learn
+
Review Comment:
unrelated to graduation name change but looks good to me regardless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] josephevans merged pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
josephevans merged PR #21148:
URL: https://github.com/apache/mxnet/pull/21148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] josephevans commented on a diff in pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
josephevans commented on code in PR #21148:
URL: https://github.com/apache/mxnet/pull/21148#discussion_r1025801474
##########
ci/docker/install/ubuntu_tutorials.sh:
##########
@@ -24,5 +24,9 @@ set -ex
apt-get update || true
apt-get install graphviz
-# sckit-learn past version 0.20 does not support python version 2 and 3.4
-pip3 install jupyter matplotlib Pillow opencv-python scikit-learn graphviz==0.8.4 tqdm mxboard scipy gluoncv
+pip3 install graphviz==0.8.4 tqdm mxboard
+pip3 install jupyter
+pip3 install matplotlib Pillow opencv-python
+pip3 install scipy gluoncv
+pip3 install scikit-learn
+
Review Comment:
Building of the docker container started hanging while installing all the PIP packages because of dependency chains, but splitting them up works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] josephevans commented on a diff in pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
josephevans commented on code in PR #21148:
URL: https://github.com/apache/mxnet/pull/21148#discussion_r1025801040
##########
.licenserc.yaml:
##########
@@ -79,6 +78,11 @@ header:
- 'include/dmlc' # symlink to 3rdparty/dmlc-core/include/dmlc
- 'include/mshadow' # symlink to 3rdparty/mshadow/mshadow
- 'include/mkldnn' # symlinks to 3rdparty/mkldnn
+ - 'include/nnvm' # symlinks to 3rdparty/tvm/nnvm/include/nnvm
+ - 'example/automatic-mixed-precision/common' # symlinks to example/image-classification/common
+ - 'example/quantization/common' # symlinks to example/image-classification/common
+ - 'scala-package/packageTest/core/scripts' # symlinks to scala-package/core/scripts
+ - 'scala-package/packageTest/examples/scripts' # symlinks to scala-package/examples/scripts
Review Comment:
The license check utility [skywalking eyes](https://github.com/apache/skywalking-eyes) has been updated to support detecting more license issues and recently started failing on these symlinks. Thus, adding them here. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on PR #21148:
URL: https://github.com/apache/incubator-mxnet/pull/21148#issuecomment-1301098951
Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-gpu, sanity, centos-gpu, windows-cpu, centos-cpu, website, edge, clang, windows-gpu, miscellaneous, unix-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] ChaiBapchya commented on a diff in pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on code in PR #21148:
URL: https://github.com/apache/mxnet/pull/21148#discussion_r1025823567
##########
.licenserc.yaml:
##########
@@ -79,6 +78,11 @@ header:
- 'include/dmlc' # symlink to 3rdparty/dmlc-core/include/dmlc
- 'include/mshadow' # symlink to 3rdparty/mshadow/mshadow
- 'include/mkldnn' # symlinks to 3rdparty/mkldnn
+ - 'include/nnvm' # symlinks to 3rdparty/tvm/nnvm/include/nnvm
+ - 'example/automatic-mixed-precision/common' # symlinks to example/image-classification/common
+ - 'example/quantization/common' # symlinks to example/image-classification/common
+ - 'scala-package/packageTest/core/scripts' # symlinks to scala-package/core/scripts
+ - 'scala-package/packageTest/examples/scripts' # symlinks to scala-package/examples/scripts
Review Comment:
skywalking eyes is such a cool name!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mxnet] ChaiBapchya commented on a diff in pull request #21148: [v1.9.x] TLP Updates
Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on code in PR #21148:
URL: https://github.com/apache/mxnet/pull/21148#discussion_r1025528071
##########
.licenserc.yaml:
##########
@@ -79,6 +78,11 @@ header:
- 'include/dmlc' # symlink to 3rdparty/dmlc-core/include/dmlc
- 'include/mshadow' # symlink to 3rdparty/mshadow/mshadow
- 'include/mkldnn' # symlinks to 3rdparty/mkldnn
+ - 'include/nnvm' # symlinks to 3rdparty/tvm/nnvm/include/nnvm
+ - 'example/automatic-mixed-precision/common' # symlinks to example/image-classification/common
+ - 'example/quantization/common' # symlinks to example/image-classification/common
+ - 'scala-package/packageTest/core/scripts' # symlinks to scala-package/core/scripts
+ - 'scala-package/packageTest/examples/scripts' # symlinks to scala-package/examples/scripts
Review Comment:
do we know why this is being added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org