You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by ja...@apache.org on 2010/06/17 23:37:31 UTC

svn commit: r955754 - /myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java

Author: jakobk
Date: Thu Jun 17 21:37:31 2010
New Revision: 955754

URL: http://svn.apache.org/viewvc?rev=955754&view=rev
Log:
MYFACES-2758 DebugPhaseListener tries to get value from unrendered component where value is unavailable

Modified:
    myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java

Modified: myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java?rev=955754&r1=955753&r2=955754&view=diff
==============================================================================
--- myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java (original)
+++ myfaces/core/trunk/impl/src/main/java/org/apache/myfaces/view/facelets/tag/ui/DebugPhaseListener.java Thu Jun 17 21:37:31 2010
@@ -20,6 +20,7 @@ package org.apache.myfaces.view.facelets
 
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.EnumSet;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -31,6 +32,7 @@ import javax.faces.component.UIComponent
 import javax.faces.component.UIViewRoot;
 import javax.faces.component.visit.VisitCallback;
 import javax.faces.component.visit.VisitContext;
+import javax.faces.component.visit.VisitHint;
 import javax.faces.component.visit.VisitResult;
 import javax.faces.context.FacesContext;
 import javax.faces.event.PhaseEvent;
@@ -303,8 +305,12 @@ public class DebugPhaseListener implemen
         UIViewRoot viewroot = event.getFacesContext().getViewRoot();
         if (viewroot != null)
         {
+            // skip all unrendered components to really only show
+            // the rendered components and to circumvent data access problems
             viewroot.visitTree(VisitContext.createVisitContext(
-                    event.getFacesContext()), _visitCallback);
+                    event.getFacesContext(), null, 
+                    EnumSet.of(VisitHint.SKIP_UNRENDERED)),
+                    _visitCallback);
         }
     }