You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/25 10:14:00 UTC

[jira] [Commented] (FLINK-10417) Add option to throw exception on pattern variable miss with SKIP_TO_FIRST/LAST

    [ https://issues.apache.org/jira/browse/FLINK-10417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627118#comment-16627118 ] 

ASF GitHub Bot commented on FLINK-10417:
----------------------------------------

dawidwys opened a new pull request #6758: [FLINK-10417] Added option to throw exception on pattern variable mis…
URL: https://github.com/apache/flink/pull/6758
 
 
   ## What is the purpose of the change
   
   Add option to throw exception when found match does not have any events mapped to variable that is used in SKIP_TO_FIRST/LAST. This is to conform with SQL standard for MATCH_RECOGNIZE.
   
   ## Brief change log
   
   * throwing exception when there is no events mapped to variable used in SKIP_TO_FIRST/LAST
   * added option to enable/disable this feature
   
   ## Verifying this change
   This change added tests and can be verified as follows:
   * `org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToFirstNonExistentPosition`
   * `org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToFirstNonExistentPositionWithoutException`
   * `org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToLastNonExistentPosition`
   * `org.apache.flink.cep.nfa.AfterMatchSkipITCase#testSkipToLastNonExistentPositionWithoutException`
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (**yes** / no)
     - If yes, how is the feature documented? (not applicable / **docs** / **JavaDocs** / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add option to throw exception on pattern variable miss with SKIP_TO_FIRST/LAST
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-10417
>                 URL: https://issues.apache.org/jira/browse/FLINK-10417
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)