You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/30 15:12:07 UTC

[GitHub] [flink] gaoyunhaii opened a new pull request #14818: [FLINK-21081][runtime][checkpoint] Re-compute the tasks to trigger if some tasks finished before get triggered

gaoyunhaii opened a new pull request #14818:
URL: https://github.com/apache/flink/pull/14818


   ## What is the purpose of the change
   
   This PR tries to re-trigger the descendent tasks if needed when some tasks finished before get triggered successfully.
   
   
   ## Brief change log
   
   - 8c90e675f53a6fd1ae52cf36350b55416470c7b3 refactors the `CheckpointCoordinator` to let `CheckpointCoordinator` decide the thread used to deal with tasks' report. This ensures the `CheckpointCoordinator` has an opportunity to record the in-process reports.
   - 127c825b086444687af34685da04e72e9fd6bc2c implements the re-triggering logic.
   
   ## Verifying this change
   
   This change added tests and can be verified via added unit tests
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): **no**
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
     - The serializers: **no**
     - The runtime per-record code paths (performance sensitive):**no**
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
     - The S3 file system connector: **no**
   
   ## Documentation
   
     - Does this pull request introduce a new feature? **no**
     - If yes, how is the feature documented? **not applicable**
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14818: [FLINK-21081][runtime][checkpoint] Re-compute the tasks to trigger if some tasks finished before get triggered

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14818:
URL: https://github.com/apache/flink/pull/14818#issuecomment-770227636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 127c825b086444687af34685da04e72e9fd6bc2c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14818: [FLINK-21081][runtime][checkpoint] Re-compute the tasks to trigger if some tasks finished before get triggered

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14818:
URL: https://github.com/apache/flink/pull/14818#issuecomment-770226619


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 127c825b086444687af34685da04e72e9fd6bc2c (Sat Jan 30 15:14:47 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
    * **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-21081).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14818: [FLINK-21081][runtime][checkpoint] Re-compute the tasks to trigger if some tasks finished before get triggered

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14818:
URL: https://github.com/apache/flink/pull/14818#issuecomment-770227636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12696",
       "triggerID" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 127c825b086444687af34685da04e72e9fd6bc2c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12696) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14818: [FLINK-21081][runtime][checkpoint] Re-compute the tasks to trigger if some tasks finished before get triggered

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14818:
URL: https://github.com/apache/flink/pull/14818#issuecomment-770227636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12696",
       "triggerID" : "127c825b086444687af34685da04e72e9fd6bc2c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 127c825b086444687af34685da04e72e9fd6bc2c Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12696) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org