[jira] [Comment Edited] (BIGTOP-2505) Support systemd containers, clean up hiera.yaml handling, fix exec (-e) flag

["Evans Ye (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15390784#comment-15390784 ] 

Evans Ye edited comment on BIGTOP-2505 at 7/23/16 5:32 PM:
-----------------------------------------------------------

Hi [~oflebbe] I'm really happy to see you to show your love to these JIRAs.
However, I found that the branch can not successfully startup a cluster on Docker for Mac, I've fixed it locally, but haven't made a patch yet.
Sorry for the delay of merging...

Anyway, there're something I'd like to discuss with you regarding to this patch:
*  We can't remove {{bash /bigtop-home/bigtop_toolchain/bin/puppetize.sh}} because vagrant-puppet-vm is still using it. We can change the {{box: "puppetlabs/centos-7.0-64-nocm"}} to be a puppetized box, but we also need to make sure that {{vagrant-puppet-openstack}} won't be effected, which I never have an environment to test it yet. :(. Maybe we just don't touch it this time?
* I'm not sure {{/sbin/init}} is gonna work for all distro. It can't run on centos 6.
* {{../../bigtop-deploy/puppet/hiera.yaml:/etc/puppet/hiera.yaml}}: I think for some day in the future we can make the images self-contained with code and config included, hence I try to centralize a copy of all configs.
* {{echo > ./config/hosts}} this is pretty.
* {{cp -rf $BIGTOP_PUPPET_DIR/hieradata ./config/}} would be better to output more logs with -v.
* {{puppet apply..}} -d can output more logs, which somehow looks like a poor version of progress bar, in my opinion. :)
* {{no=$(($1-1))}} I did this for a reason that users see the number started from 1 when using docker-compose scale:
{code}
Creating and starting 20160724012000r227_bigtop_1 ... done
Creating and starting 20160724012000r227_bigtop_2 ... done
{code}
Hence starting at 1 would be much more intuitive and easier to guess.


was (Author: evans_ye):
Hi [~oflebbe] I'm really happy to see you to show your love to these JIRAs.
However, I found that the branch can not successfully startup a cluster on Docker for Mac, I've fixed it locally, but haven't made a patch yet.
Sorry for the delay of merging...

Anyway, there're something I'd like to discuss with you regarding to this patch:
*  We can't remove {{bash /bigtop-home/bigtop_toolchain/bin/puppetize.sh}} because vagrant-puppet-vm is still using it. We can change the {{box: "puppetlabs/centos-7.0-64-nocm"}} to be a puppetized box, but we also need to make sure that {{vagrant-puppet-openstack}} won't be effected, which I never have an environment to test it yet. :(. Maybe we just don't touch it this time?
* I'm not sure {{/sbin/init}} is gonna work for all distro. It can't run on centos 6.
* {{../../bigtop-deploy/puppet/hiera.yaml:/etc/puppet/hiera.yaml}}: I think for some day in the future we can make the images self-contained with code and config included, hence I try to centralize a copy of all configs.
* {{echo > ./config/hosts}} this is pretty.
* {{cp -rf $BIGTOP_PUPPET_DIR/hieradata ./config/}} would be better to output more logs with -v.
* {{puppet apply..}} -d can output more logs, which somehow looks like a poor version of progress bar, in my opinion. :)
* {{docker exec -ti ${NODES[$((no-1))]} $@}} I did this for a reason that users see the number started from 1 when using docker-compose scale:
{code}
Creating and starting 20160724012000r227_bigtop_1 ... done
Creating and starting 20160724012000r227_bigtop_2 ... done
{code}
Hence starting at 1 would be much more intuitive and easier to guess.

> Support systemd containers, clean up hiera.yaml handling, fix exec (-e) flag
> ----------------------------------------------------------------------------
>
>                 Key: BIGTOP-2505
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2505
>             Project: Bigtop
>          Issue Type: Sub-task
>          Components: provisioner
>            Reporter: Olaf Flebbe
>            Assignee: Olaf Flebbe
>         Attachments: BIGTOP-2505.1.patch
>
>
> Hi [~evans_ye],
> I think the brach BIGTOP-2253  can be improved. Hope you like it.
> Olaf



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)