You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2020/09/18 10:47:13 UTC

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties 

Zoltan Borok-Nagy has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16472


Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................

IMPALA-9652: CTAS doesn't respect transactional properties

Because of a bug the INSERT part of a CTAS statement didn't
run in a transaction.

Testing:
* Added CTAS statements and SHOW FILES <tbl> queries to acid-insert.test
  Check if the files are created in a delta directory, if so, then
  the INSERT must have been running in a transaction.

Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M testdata/workloads/functional-query/queries/QueryTest/acid-insert.test
2 files changed, 56 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/16472/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:55:55 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6451/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 09:08:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 3: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6446/


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 18:13:39 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Hello Csaba Ringhofer, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/16472

to look at the new patch set (#2).

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................

IMPALA-9652: CTAS doesn't respect transactional properties

Because of a bug the INSERT part of a CTAS statement didn't
run in a transaction and it just put the new files under the
root directory of the table. This didn't cause too much problems
because there couldn't be any concurrent operations as the table was
under construction. However, this behavior is not working particularly
well in the context of replication, as the notification event needs
a transaction id.

With this fix the INSERT operation runs in a transaction and the new
files are created under a delta directory.

Testing:
* Added CTAS statements and SHOW FILES <tbl> queries to acid-insert.test
  Check if the files are created in a delta directory, if so, then
  the INSERT must have been running in a transaction.

Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M testdata/workloads/functional-query/queries/QueryTest/acid-insert.test
2 files changed, 56 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/16472/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 4: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 20:10:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7194/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 11:08:50 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6443/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 10:53:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 1: Code-Review+2

(3 comments)

Thanks for fixing these bugs, I have only nits.

http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@9
PS1, Line 9: Because of a bug the INSERT part of a CTAS statement didn't
Can you add more info about how we worked before the change, and how we will work after it? E.g. before the change the files written by CTAS were put the the root directory as original files. After the change the files will go to a delta directory like for insert and the table will be locked during the operation.


http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@10
PS1, Line 10: transaction
Do I understand well that we are still not transactional in a multi table sense? So while the source tables will be locked, no refresh is done on them and the new table can be created based on their state at a previous transaction id.


http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test
File testdata/workloads/functional-query/queries/QueryTest/acid-insert.test:

http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test@65
PS1, Line 65: ====
            : ---- QUERY
            : drop table insertonly_nopart_ctas;
Is there a reason why we do the cleanup here? The whole DB is dropped after running the test.



-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 11:23:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6446/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:55:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 09:08:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 16:05:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6451/


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 14:26:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@9
PS1, Line 9: Because of a bug the INSERT part of a CTAS statement didn't
> Can you add more info about how we worked before the change, and how we wil
Done


http://gerrit.cloudera.org:8080/#/c/16472/1//COMMIT_MSG@10
PS1, Line 10: transaction
> Do I understand well that we are still not transactional in a multi table s
Yes, it works like the INSERT statements.
IMPALA-8788 is tracking the transactional behavior that you described. It would be a bigger chunk of work, and with event polling we almost always use the latest snapshots of the tables. But I agree that it should be fixed ideally.


http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test
File testdata/workloads/functional-query/queries/QueryTest/acid-insert.test:

http://gerrit.cloudera.org:8080/#/c/16472/1/testdata/workloads/functional-query/queries/QueryTest/acid-insert.test@65
PS1, Line 65: ====
            : ---- QUERY
            : drop table insertonly_nopart_ctas;
> Is there a reason why we do the cleanup here? The whole DB is dropped after
I find it good practice to DROP tables after their last use. E.g. if you are copy pasting some tests it's better to get an error message than to use the wrong table.



-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:45:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................

IMPALA-9652: CTAS doesn't respect transactional properties

Because of a bug the INSERT part of a CTAS statement didn't
run in a transaction and it just put the new files under the
root directory of the table. This didn't cause too much problems
because there couldn't be any concurrent operations as the table was
under construction. However, this behavior is not working particularly
well in the context of replication, as the notification event needs
a transaction id.

With this fix the INSERT operation runs in a transaction and the new
files are created under a delta directory.

Testing:
* Added CTAS statements and SHOW FILES <tbl> queries to acid-insert.test
  Check if the files are created in a delta directory, if so, then
  the INSERT must have been running in a transaction.

Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Reviewed-on: http://gerrit.cloudera.org:8080/16472
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/Frontend.java
M testdata/workloads/functional-query/queries/QueryTest/acid-insert.test
2 files changed, 56 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 5
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6452/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 4
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2020 14:50:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-9652: CTAS doesn't respect transactional properties

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/16472 )

Change subject: IMPALA-9652: CTAS doesn't respect transactional properties
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16472
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ed96aeadbcead9fdc548da5922a066460ff9f77
Gerrit-Change-Number: 16472
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 18 Sep 2020 12:54:34 +0000
Gerrit-HasComments: No