[GitHub] [nifi] markap14 commented on a change in pull request #5544: NIFI-9389 - NPE guard for ExecuteProcess on no OnTriggered

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #5544:
URL: https://github.com/apache/nifi/pull/5544#discussion_r754546885



##########
File path: nifi-mock/src/main/java/org/apache/nifi/util/TestRunner.java
##########
@@ -61,6 +61,13 @@
      */
     ProcessContext getProcessContext();
 
+    /**
+     * Call the {@link org.apache.nifi.annotation.lifecycle.OnScheduled} /
+     * {@link org.apache.nifi.annotation.lifecycle.OnUnscheduled} methods, to simulate a processor
+     * that is enabled but never triggered.
+     */
+    void doNotRun();

Review comment:
       I would agree with you here @exceptionfactory. There already exists an `unSchedule` method on TestRunner, it appears. And an `onStopped`. Would recommend just added a `schedule` method - or allowing `0` as an acceptable number of iterations to the `run` method. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org