[GitHub] [flink] azagrebin edited a comment on issue #10682: [FLINK-15247][Runtime] Wait for all slots to be free before task executor services shutdown upon stopping

[GitBox <gi...@apache.org>]

azagrebin edited a comment on issue #10682: [FLINK-15247][Runtime] Wait for all slots to be free before task executor services shutdown upon stopping
URL: https://github.com/apache/flink/pull/10682#issuecomment-576353246
 
 
   Thanks for the review @tillrohrmann 
   I addressed the comments.
   
   I think the safest way to handle timer service concurrency issues is to schedule its stopping to the main thread of task executor. Then there is only a thread-confined access to its internal container for registered callbacks. I updated PR accordingly.
   
   In long term, we should try to make `Task#notifyFinalState` synced with its terminal future because  internal state of slot and table is managed in main thread inside task executor from `notifyFinalState` and the introduced closing is resulted from terminal futures. This leads to some table methods being called after the closed state is reached. This does not look as an immediate problem atm but complicates judging about the components. The same applies to the mentioned separation of responsibilities: TE -> table -> slot -> task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services