You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/06 13:06:03 UTC
[GitHub] [flink] XComp commented on a diff in pull request #20925: [FLINK-29468][connectors][filesystems][formats] Update Jackson-BOM to 2.13.4
XComp commented on code in PR #20925:
URL: https://github.com/apache/flink/pull/20925#discussion_r988616500
##########
pom.xml:
##########
@@ -599,7 +599,7 @@ under the License.
<artifactId>jackson-bom</artifactId>
<type>pom</type>
<scope>import</scope>
- <version>2.13.2.20220328</version>
+ <version>2.13.4</version>
Review Comment:
```suggestion
<version>${other.dependencies.jackson.version}</version>
```
I'm wondering whether we should introduce a property for the version. Its declaration would be put right below `<flink.shaded.jackson.version/>` or `<bom.jackson.version>` to have a single location reflecting the different Jackson versions. WDYT? We could add a comment there as well which explains why we use different versions (flink-shaded for Flink-internal usage and the bom for dependencies that use the Jackson libraries as dependencies where we don't want to apply relocation to match the flink-shaded version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org