You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "jinmeiliao (GitHub)" <gi...@apache.org> on 2018/10/31 17:25:23 UTC
[GitHub] [geode] jinmeiliao opened pull request #2754: GEODE-5943: rework calculation for expected eviction to fix this test…
… in jdk11
Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2754 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao commented on pull request #2754: GEODE-5943: rework calculation for expected eviction to fix this test…
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
yeah, I think since the eviction happens on another thread, this awaitility is there only to wait till we are close to examine the actual evictions that has happened.
[ Full content available at: https://github.com/apache/geode/pull/2754 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jinmeiliao closed pull request #2754: GEODE-5943: rework calculation for expected eviction to fix this test…
Posted by "jinmeiliao (GitHub)" <gi...@apache.org>.
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2754 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jhuynh1 commented on pull request #2754: GEODE-5943: rework calculation for expected eviction to fix this test…
Posted by "jhuynh1 (GitHub)" <gi...@apache.org>.
Won't this always be true? If expectedEviction is 1 and totalEvictions is 0 then subtracting 0-1 and taking the abs will always be <= 1?
If expected is 10 and total is 0, then again it's bigger than 1?
My math brain isn't quite on this morning so I might be totally off...
[ Full content available at: https://github.com/apache/geode/pull/2754 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] jhuynh1 commented on pull request #2754: GEODE-5943: rework calculation for expected eviction to fix this test…
Posted by "jhuynh1 (GitHub)" <gi...@apache.org>.
Won't this always be true? If expectedEviction is 1 and totalEvictions is 0 then subtracting 0-1 and taking the abs will always be <= 1?
Ok I think I'm an idiot, this probably doesn't happen
[ Full content available at: https://github.com/apache/geode/pull/2754 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org