You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by iamrakesh <gi...@git.apache.org> on 2016/01/12 18:06:44 UTC
[GitHub] wicket pull request: Error page redirection support for autocomple...
GitHub user iamrakesh opened a pull request:
https://github.com/apache/wicket/pull/156
Error page redirection support for autocomplete ajax response
Autocomplete field resulting an exception with
org.apache.wicket.settings.ExceptionSettings#errorHandlingStrategyDuringAjaxRequests,
set to
org.apache.wicket.settings.ExceptionSettings.AjaxErrorStrategy.REDIRECT_TO_ERROR_PAGE
does not redirect to the error page.
This fix will enable page redirection even for autocomplete field.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iamrakesh/wicket autocomplete-error-handling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #156
----
commit 34e04fed93808716d2a11cb818379b12923a1f48
Author: iamrakesh <ra...@hotmail.co.in>
Date: 2016-01-12T16:49:38Z
Added support for page redirection for autocomplete ajax response.
commit fa2c6f2949018bc65a63570130d510217ae0f914
Author: iamrakesh <ra...@hotmail.co.in>
Date: 2016-01-12T16:53:00Z
Minor cleanup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Error page redirection support for autocomple...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/156#issuecomment-171038199
Please create a ticket in JIRA with a quickstart for the problem in autocomplete.
I just checked the diff and I see that you actually modified wicket-ajax-jquery.js, not wicket-autocomplete.js. Changes here need more attention before applying!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Error page redirection support for autocomple...
Posted by iamrakesh <gi...@git.apache.org>.
Github user iamrakesh commented on the pull request:
https://github.com/apache/wicket/pull/156#issuecomment-170981202
Not sure about JavaScript test added, as I see all tests (part of all.html) go green always.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Error page redirection support for autocomple...
Posted by iamrakesh <gi...@git.apache.org>.
Github user iamrakesh commented on the pull request:
https://github.com/apache/wicket/pull/156#issuecomment-171163788
Yes, changes to wicket-ajax-jquery.js need more attention, created a ticket for it with description
https://issues.apache.org/jira/browse/WICKET-6075
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Error page redirection support for autocomple...
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/156#issuecomment-170982490
wicket-core/src/test/js/** cover only the .js files in -core.
There are no *unit* JS tests for -extensions module.
In https://github.com/apache/wicket/tree/master/wicket-examples/src/main/webapp/js-test there are *functional* tests though for some of the examples. There is no such for the autocomplete example yet.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---