You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/26 06:55:03 UTC
[GitHub] [shardingsphere] soulasuna opened a new pull request, #19563: Optimizing worker-id generation by in-memory computing in cluster mode
soulasuna opened a new pull request, #19563:
URL: https://github.com/apache/shardingsphere/pull/19563
## Optimizing worker-id generation by in-memory computing in cluster mode
Changes proposed in this pull request:
- Optimizing worker-id generation by in-memory computing in cluster mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #19563: Optimizing worker-id generation by in-memory computing in cluster mode
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19563:
URL: https://github.com/apache/shardingsphere/pull/19563#issuecomment-1195160686
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/19563?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19563](https://codecov.io/gh/apache/shardingsphere/pull/19563?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ddcf8cd) into [master](https://codecov.io/gh/apache/shardingsphere/commit/b4fa59e6f5ba1bd3555e8a4afc32bb6c38d6e928?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b4fa59e) will **increase** coverage by `0.01%`.
> The diff coverage is `68.57%`.
```diff
@@ Coverage Diff @@
## master #19563 +/- ##
============================================
+ Coverage 60.13% 60.14% +0.01%
- Complexity 2389 2394 +5
============================================
Files 3825 3834 +9
Lines 54442 54517 +75
Branches 7612 7621 +9
============================================
+ Hits 32736 32790 +54
- Misses 18901 18924 +23
+ Partials 2805 2803 -2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/19563?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dingsphere/infra/instance/ComputeNodeInstance.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9Db21wdXRlTm9kZUluc3RhbmNlLmphdmE=) | `42.85% <ø> (ø)` | |
| [...atus/compute/service/ComputeNodeStatusService.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS9zdGF0dXMvY29tcHV0ZS9zZXJ2aWNlL0NvbXB1dGVOb2RlU3RhdHVzU2VydmljZS5qYXZh) | `66.66% <0.00%> (-3.93%)` | :arrow_down: |
| [...lgorithm/keygen/SnowflakeKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvYWxnb3JpdGhtL2tleWdlbi9Tbm93Zmxha2VLZXlHZW5lcmF0ZUFsZ29yaXRobS5qYXZh) | `89.79% <60.00%> (+1.33%)` | :arrow_up: |
| [...y/workerid/generator/ClusterWorkerIdGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtbW9kZS9zaGFyZGluZ3NwaGVyZS1tb2RlLXR5cGUvc2hhcmRpbmdzcGhlcmUtY2x1c3Rlci1tb2RlL3NoYXJkaW5nc3BoZXJlLWNsdXN0ZXItbW9kZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21hbmFnZXIvY2x1c3Rlci9jb29yZGluYXRvci9yZWdpc3RyeS93b3JrZXJpZC9nZW5lcmF0b3IvQ2x1c3RlcldvcmtlcklkR2VuZXJhdG9yLmphdmE=) | `75.86% <72.72%> (+9.19%)` | :arrow_up: |
| [...thm/keygen/CosIdSnowflakeKeyGenerateAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctcGx1Z2luL3NoYXJkaW5nc3BoZXJlLXNoYXJkaW5nLWNvc2lkL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9jb3NpZC9hbGdvcml0aG0va2V5Z2VuL0Nvc0lkU25vd2ZsYWtlS2V5R2VuZXJhdGVBbGdvcml0aG0uamF2YQ==) | `100.00% <100.00%> (+3.33%)` | :arrow_up: |
| [...shardingsphere/infra/instance/InstanceContext.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9pbnN0YW5jZS9JbnN0YW5jZUNvbnRleHQuamF2YQ==) | `53.84% <100.00%> (+3.84%)` | :arrow_up: |
| [...end/text/distsql/DistSQLBackendHandlerFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvRGlzdFNRTEJhY2tlbmRIYW5kbGVyRmFjdG9yeS5qYXZh) | `36.84% <0.00%> (-4.34%)` | :arrow_down: |
| [...nse/header/query/impl/MySQLQueryHeaderBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9yZXNwb25zZS9oZWFkZXIvcXVlcnkvaW1wbC9NeVNRTFF1ZXJ5SGVhZGVyQnVpbGRlci5qYXZh) | `88.88% <0.00%> (-3.71%)` | :arrow_down: |
| [...nfra/metadata/database/ShardingSphereDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | `67.50% <0.00%> (-1.74%)` | :arrow_down: |
| [...nication/jdbc/JDBCDatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9jb21tdW5pY2F0aW9uL2pkYmMvSkRCQ0RhdGFiYXNlQ29tbXVuaWNhdGlvbkVuZ2luZS5qYXZh) | `50.00% <0.00%> (-1.17%)` | :arrow_down: |
| ... and [49 more](https://codecov.io/gh/apache/shardingsphere/pull/19563/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #19563: Optimizing worker-id generation by in-memory computing in cluster mode
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on code in PR #19563:
URL: https://github.com/apache/shardingsphere/pull/19563#discussion_r929657986
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/ComputeNodeInstance.java:
##########
@@ -41,6 +41,8 @@ public final class ComputeNodeInstance {
private Collection<String> labels = new ArrayList<>();
+ private volatile Long workerId;
Review Comment:
Could we change this to primitive type?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] soulasuna commented on a diff in pull request #19563: Optimizing worker-id generation by in-memory computing in cluster mode
Posted by GitBox <gi...@apache.org>.
soulasuna commented on code in PR #19563:
URL: https://github.com/apache/shardingsphere/pull/19563#discussion_r929679427
##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/instance/ComputeNodeInstance.java:
##########
@@ -41,6 +41,8 @@ public final class ComputeNodeInstance {
private Collection<String> labels = new ArrayList<>();
+ private volatile Long workerId;
Review Comment:
Of course i will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] menghaoranss merged pull request #19563: Optimizing worker-id generation by in-memory computing in cluster mode
Posted by GitBox <gi...@apache.org>.
menghaoranss merged PR #19563:
URL: https://github.com/apache/shardingsphere/pull/19563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org