[GitHub] [accumulo] ctubbsii commented on a diff in pull request #2746: Allow overriding default env without editing conf

[GitBox <gi...@apache.org>]

ctubbsii commented on code in PR #2746:
URL: https://github.com/apache/accumulo/pull/2746#discussion_r884176044


##########
assemble/conf/accumulo-env.sh:
##########
@@ -73,11 +73,13 @@ export CLASSPATH
 
 ## JVM options set for all processes. Extra options can be passed in by setting ACCUMULO_JAVA_OPTS to an array of options.
 read -r -a accumulo_initial_opts < <(echo "$ACCUMULO_JAVA_OPTS")
-JAVA_OPTS=("${accumulo_initial_opts[@]}"
+JAVA_OPTS=(
   '-XX:OnOutOfMemoryError=kill -9 %p'
   '-XX:-OmitStackTraceInFastThrow'
   '-Djava.net.preferIPv4Stack=true'
-  "-Daccumulo.native.lib.path=${lib}/native")
+  "-Daccumulo.native.lib.path=${lib}/native"
+  "${accumulo_initial_opts[@]}"

Review Comment:
   If they can't, then this change fixes one use case, but harms another. We'd need to decide which is a better default. In the end, this is a user configurable file, and it's really up to the user to make sure their config is doing what they need. So, I'm not too worried about it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org