You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Dan Dumont <dd...@us.ibm.com> on 2011/09/10 03:46:31 UTC
Re: Review Request: shared-script-frame feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/
-----------------------------------------------------------
(Updated 2011-09-10 01:46:31.551719)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew Davis.
Changes
-------
Adding shindig.
Summary
-------
Adding a new feature to shindig to support a shared-script-frame feature. Gadgets can request that a view of itself be rendered before any other view is rendered.
The container will hide this gadget view (no-ui) and give the gadget iframe a name so that other gadget views from the same gadget can reference it and use it as a single script store.
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/1749/diff
Testing
-------
Thanks,
Dan
Re: Review Request: shared-script-frame feature
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/#review1973
-----------------------------------------------------------
Ship it!
Committed revision 1173254. We can update the name of the feature based on the review of the spec changes.
- Ryan
On 2011-09-13 18:09:05, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1749/
> -----------------------------------------------------------
>
> (Updated 2011-09-13 18:09:05)
>
>
> Review request for shindig, johnfargo, Ryan Baxter, Michael Hermanto, Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew Davis.
>
>
> Summary
> -------
>
> Adding a new feature to shindig to support a shared-script-frame feature. Gadgets can request that a view of itself be rendered before any other view is rendered.
> The container will hide this gadget view (no-ui) and give the gadget iframe a name so that other gadget views from the same gadget can reference it and use it as a single script store.
>
>
> This addresses bug SHINDIG-1620.
> https://issues.apache.org/jira/browse/SHINDIG-1620
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1749/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: shared-script-frame feature
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/#review1870
-----------------------------------------------------------
One nit, I am not to fond of the feature name 'script-frame'. From the gadget Dev point of view it's more of a script view than a frame.
- Ryan
On 2011-09-13 18:09:05, Dan Dumont wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1749/
> -----------------------------------------------------------
>
> (Updated 2011-09-13 18:09:05)
>
>
> Review request for shindig, johnfargo, Ryan Baxter, Michael Hermanto, Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew Davis.
>
>
> Summary
> -------
>
> Adding a new feature to shindig to support a shared-script-frame feature. Gadgets can request that a view of itself be rendered before any other view is rendered.
> The container will hide this gadget view (no-ui) and give the gadget iframe a name so that other gadget views from the same gadget can reference it and use it as a single script store.
>
>
> This addresses bug SHINDIG-1620.
> https://issues.apache.org/jira/browse/SHINDIG-1620
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml PRE-CREATION
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1166716
> http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml PRE-CREATION
>
> Diff: https://reviews.apache.org/r/1749/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan
>
>
Re: Review Request: shared-script-frame feature
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/
-----------------------------------------------------------
(Updated 2011-09-13 18:09:05.479371)
Review request for shindig, johnfargo, Ryan Baxter, Michael Hermanto, Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew Davis.
Changes
-------
Adding johnfargo and mhermanto, can you guys give this a once-over?
Summary
-------
Adding a new feature to shindig to support a shared-script-frame feature. Gadgets can request that a view of itself be rendered before any other view is rendered.
The container will hide this gadget view (no-ui) and give the gadget iframe a name so that other gadget views from the same gadget can reference it and use it as a single script store.
This addresses bug SHINDIG-1620.
https://issues.apache.org/jira/browse/SHINDIG-1620
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/1749/diff
Testing
-------
Thanks,
Dan
Re: Review Request: shared-script-frame feature
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1749/
-----------------------------------------------------------
(Updated 2011-09-10 02:04:53.296881)
Review request for shindig, Ryan Baxter, Jason Chiang, Matthew Hatem, Stanton Sievers, Igor Belakovskiy, and Andrew Davis.
Changes
-------
Adding jira
Summary
-------
Adding a new feature to shindig to support a shared-script-frame feature. Gadgets can request that a view of itself be rendered before any other view is rendered.
The container will hide this gadget view (no-ui) and give the gadget iframe a name so that other gadget views from the same gadget can reference it and use it as a single script store.
This addresses bug SHINDIG-1620.
https://issues.apache.org/jira/browse/SHINDIG-1620
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/taming.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1166716
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/feature.xml PRE-CREATION
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1166716
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/SharedScriptFrameDemo.xml PRE-CREATION
Diff: https://reviews.apache.org/r/1749/diff
Testing
-------
Thanks,
Dan