(kafka) branch trunk updated: add slf4jlog4j in tool (#16260)

[sh...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

showuon pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 31c55b630b6 add slf4jlog4j in tool (#16260)
31c55b630b6 is described below

commit 31c55b630b6bb5c4ea7768bcf54d05a35c4014f5
Author: Luke Chen <sh...@gmail.com>
AuthorDate: Tue Jun 11 09:43:35 2024 +0900

    add slf4jlog4j in tool (#16260)
    
    In #12148 , we removed log4jAppender dependency, and add testImplementation dependency for slf4jlog4j lib. However, we need this runtime dependency in tools module to output logs. (ref) Adding this dependency back.
    
    Note: The slf4jlog4j lib was added in log4j-appender dependency. Since it's removed, we need to explicitly declare it.
    
    Reviewers: Chia-Ping Tsai <ch...@gmail.com>, Edoardo Comar <ec...@uk.ibm.com>
---
 build.gradle | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/build.gradle b/build.gradle
index ee51d2edc79..d46252c623e 100644
--- a/build.gradle
+++ b/build.gradle
@@ -2167,7 +2167,6 @@ project(':tools') {
   }
 
   dependencies {
-    compileOnly libs.slf4jlog4j
     implementation project(':clients')
     implementation project(':storage')
     implementation project(':server-common')
@@ -2178,6 +2177,7 @@ project(':tools') {
     implementation libs.jacksonDataformatCsv
     implementation libs.jacksonJDK8Datatypes
     implementation libs.slf4jApi
+    implementation libs.slf4jlog4j
     implementation libs.joptSimple
 
     implementation libs.jose4j                    // for SASL/OAUTHBEARER JWT validation
@@ -2204,7 +2204,6 @@ project(':tools') {
       exclude group: 'junit', module: 'junit'
     }
     testImplementation libs.log4j
-    testRuntimeOnly libs.slf4jlog4j
   }
 
   javadoc {