You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Andrew Grieve (JIRA)" <ji...@apache.org> on 2012/11/07 17:19:11 UTC

[jira] [Created] (CB-1822) Move cordova.ios.js to CordovaLib directory

Andrew Grieve created CB-1822:
---------------------------------

             Summary: Move cordova.ios.js to CordovaLib directory
                 Key: CB-1822
                 URL: https://issues.apache.org/jira/browse/CB-1822
             Project: Apache Cordova
          Issue Type: Bug
          Components: iOS
            Reporter: Andrew Grieve
            Assignee: Andrew Grieve
            Priority: Minor
             Fix For: 2.3.0


Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo

This change involves:
1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
2. Remove VERSION from bin/templates/project/www/index.html
3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
5. Add a build phase to CordovaLibApp to copy the .js file into it's www


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1822) Move cordova.ios.js to CordovaLib directory

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492572#comment-13492572 ] 

Andrew Grieve commented on CB-1822:
-----------------------------------

Sorry for not being clear. I have no plans on changing the VERSION file. not sure why I like to write VERSION in all caps :P
                
> Move cordova.ios.js to CordovaLib directory
> -------------------------------------------
>
>                 Key: CB-1822
>                 URL: https://issues.apache.org/jira/browse/CB-1822
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo
> This change involves:
> 1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
> 2. Remove VERSION from bin/templates/project/www/index.html
> 3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
> 4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
> 5. Add a build phase to CordovaLibApp to copy the .js file into it's www

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1822) Move cordova.ios.js to CordovaLib directory

Posted by "Kevin Hawkins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492578#comment-13492578 ] 

Kevin Hawkins commented on CB-1822:
-----------------------------------

Great, thanks!  That will work perfectly for us. ;-)
                
> Move cordova.ios.js to CordovaLib directory
> -------------------------------------------
>
>                 Key: CB-1822
>                 URL: https://issues.apache.org/jira/browse/CB-1822
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo
> This change involves:
> 1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
> 2. Remove VERSION from bin/templates/project/www/index.html
> 3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
> 4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
> 5. Add a build phase to CordovaLibApp to copy the .js file into it's www

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1822) Move cordova.ios.js to CordovaLib directory

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve resolved CB-1822.
-------------------------------

    Resolution: Fixed

https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-ios.git;a=commit;h=c65aadf52b966a72f47fd15ac9a0448947f0df9f
                
> Move cordova.ios.js to CordovaLib directory
> -------------------------------------------
>
>                 Key: CB-1822
>                 URL: https://issues.apache.org/jira/browse/CB-1822
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo
> This change involves:
> 1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
> 2. Remove VERSION from bin/templates/project/www/index.html
> 3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
> 4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
> 5. Add a build phase to CordovaLibApp to copy the .js file into it's www

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (CB-1822) Move cordova.ios.js to CordovaLib directory

Posted by "Kevin Hawkins (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CB-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13492556#comment-13492556 ] 

Kevin Hawkins commented on CB-1822:
-----------------------------------

What are the details around removing/moving VERSION?  With our current framework, which consumes Cordova and presents our own "version" of a hybrid app framework, it's helpful that the version is parseable, as we do not make use of the Cordova app creation template/code, so we have to recreate this process to a degree.

Can we keep the version information as something that's somewhat externally parseable, as opposed to, say, tightly coupling it with the creation script?
                
> Move cordova.ios.js to CordovaLib directory
> -------------------------------------------
>
>                 Key: CB-1822
>                 URL: https://issues.apache.org/jira/browse/CB-1822
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo
> This change involves:
> 1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
> 2. Remove VERSION from bin/templates/project/www/index.html
> 3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
> 4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
> 5. Add a build phase to CordovaLibApp to copy the .js file into it's www

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (CB-1822) Move cordova.ios.js to CordovaLib directory

Posted by "Andrew Grieve (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Grieve updated CB-1822:
------------------------------

    Description: 
Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo

This change involves:
1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
2. Remove VERSION from bin/templates/project/www/index.html
3. Remove VERSION-adding logic from Makefile and update the create script
4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
5. Add a build phase to CordovaLibApp to copy the .js file into it's www


  was:
Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo

This change involves:
1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
2. Remove VERSION from bin/templates/project/www/index.html
3. Move VERSION-adding logic from Makefile into the create script, and have it also copy the .js from the new location
4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
5. Add a build phase to CordovaLibApp to copy the .js file into it's www


    
> Move cordova.ios.js to CordovaLib directory
> -------------------------------------------
>
>                 Key: CB-1822
>                 URL: https://issues.apache.org/jira/browse/CB-1822
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Relevant ML thread: http://callback.markmail.org/thread/5m5qiv3vokwyuxyo
> This change involves:
> 1. Move from bin/templates/project/www/{cordova-VERSION.js to CordovaLib/cordova.ios.js 
> 2. Remove VERSION from bin/templates/project/www/index.html
> 3. Remove VERSION-adding logic from Makefile and update the create script
> 4. Delete CordovaLibTests/CordovaLibApp/www/cordova.ios.js
> 5. Add a build phase to CordovaLibApp to copy the .js file into it's www

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira