You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by ji...@apache.org on 2020/09/18 05:57:56 UTC

[rocketmq] branch develop updated: [ISSUE #2152] Use mock style in unit test for time-consuming (#2308)

This is an automated email from the ASF dual-hosted git repository.

jinrongtong pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/rocketmq.git


The following commit(s) were added to refs/heads/develop by this push:
     new b29209e  [ISSUE #2152] Use mock style in unit test for time-consuming (#2308)
b29209e is described below

commit b29209e59ac44760d071094c30a6507719e33121
Author: anotherJJz <47...@qq.com>
AuthorDate: Fri Sep 18 13:57:38 2020 +0800

    [ISSUE #2152] Use mock style in unit test for time-consuming (#2308)
---
 .../client/consumer/DefaultLitePullConsumerTest.java  | 19 +++++++++----------
 1 file changed, 9 insertions(+), 10 deletions(-)

diff --git a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
index 3726a5b..6683270 100644
--- a/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
+++ b/client/src/test/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumerTest.java
@@ -20,10 +20,8 @@ package org.apache.rocketmq.client.consumer;
 import java.io.ByteArrayOutputStream;
 import java.lang.reflect.Field;
 import java.net.InetSocketAddress;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.List;
-import java.util.Set;
+import java.util.*;
+
 import org.apache.rocketmq.client.ClientConfig;
 import org.apache.rocketmq.client.consumer.store.OffsetStore;
 import org.apache.rocketmq.client.consumer.store.ReadOffsetType;
@@ -515,11 +513,14 @@ public class DefaultLitePullConsumerTest {
 
     @Test
     public void testConsumerAfterShutdown() throws Exception {
-        DefaultLitePullConsumer defaultLitePullConsumer = createStartLitePullConsumer();
-        defaultLitePullConsumer.setNamesrvAddr("127.0.0.1:9876");
-        defaultLitePullConsumer.subscribe(topic, "*");
+        DefaultLitePullConsumer defaultLitePullConsumer = createSubscribeLitePullConsumer();
+
+        DefaultLitePullConsumer mockConsumer = spy(defaultLitePullConsumer);
+        when(mockConsumer.poll(anyLong())).thenReturn(new ArrayList<>());
+
         new AsyncConsumer().executeAsync(defaultLitePullConsumer);
-        Thread.sleep(10 * 1000);
+
+        Thread.sleep(100);
         defaultLitePullConsumer.shutdown();
         assertThat(defaultLitePullConsumer.isRunning()).isFalse();
     }
@@ -531,9 +532,7 @@ public class DefaultLitePullConsumerTest {
                 public void run() {
                     while (consumer.isRunning()) {
                         List<MessageExt> poll = consumer.poll(2 * 1000);
-                        System.out.println("consumer is still running");
                     }
-                    System.out.println("consumer shutdown");
                 }
             }).start();
         }