You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2021/12/02 23:46:11 UTC
[Impala-ASF-CR] IMPALA-11046: Change GetTupleIdx assert to a fail.
Steve Carlin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18065
Change subject: IMPALA-11046: Change GetTupleIdx assert to a fail.
......................................................................
IMPALA-11046: Change GetTupleIdx assert to a fail.
There is code within GetTupleIdx that asserts that the index
is in range. The code also returns INVALID_IDX if the index
is not in the map.
It is preferable to be consistent with how GetTupleIdx fails when
the index is not in the map. During debugging, I hit this issue
and found it preferable to fail the query (which the caller of
GetTupleIdx does) rather than cause impalad to crash.
Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
---
M be/src/runtime/descriptors.cc
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/18065/1
--
To view, visit http://gerrit.cloudera.org:8080/18065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
Gerrit-Change-Number: 18065
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
[Impala-ASF-CR] IMPALA-11046: Change GetTupleIdx assert to a fail.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18065 )
Change subject: IMPALA-11046: Change GetTupleIdx assert to a fail.
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9866/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
Gerrit-Change-Number: 18065
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 00:07:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11046: Change GetTupleIdx assert to a fail.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18065 )
Change subject: IMPALA-11046: Change GetTupleIdx assert to a fail.
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7689/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
Gerrit-Change-Number: 18065
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 00:31:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11046: Change GetTupleIdx assert to a fail.
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18065 )
Change subject: IMPALA-11046: Change GetTupleIdx assert to a fail.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
Gerrit-Change-Number: 18065
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Dec 2021 06:46:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11046: Change GetTupleIdx assert to a fail.
Posted by "Steve Carlin (Code Review)" <ge...@cloudera.org>.
Steve Carlin has abandoned this change. ( http://gerrit.cloudera.org:8080/18065 )
Change subject: IMPALA-11046: Change GetTupleIdx assert to a fail.
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18065
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I15767b7adc30b4e6fdcf2e76b673a61739e5a289
Gerrit-Change-Number: 18065
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>