[jira] [Commented] (HBASE-3893) HRegion.internalObtainRowLock shouldn't wait forever

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061526#comment-13061526 ] 

stack commented on HBASE-3893:
------------------------------

Why do this:

{code}
+    this.rowLockWaitDuration = 30000;
{code}

when later you do this:

{code}
+    this.rowLockWaitDuration = conf.getInt("hbase.rowlock.wait.duration", 30000);
{code}


Otherwise, +1 on commit.


> HRegion.internalObtainRowLock shouldn't wait forever
> ----------------------------------------------------
>
>                 Key: HBASE-3893
>                 URL: https://issues.apache.org/jira/browse/HBASE-3893
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.90.2
>            Reporter: Jean-Daniel Cryans
>            Assignee: Ted Yu
>            Priority: Blocker
>             Fix For: 0.90.4
>
>         Attachments: 3893.txt
>
>
> We just had a weird episode where one user was trying to insert a lot of data with overlapping keys into a single region (all of that is a separate problem), and the region server rapidly filled up all it's handlers + queues with those calls. Basically it wasn't deadlocked but almost.
> Worse, now that we have a 60 seconds socket timeout the clients were eventually getting the timeout and then retrying another call to that same region server.
> We should have a timeout on lockedRows.wait() in HRegion.internalObtainRowLock in order to survive this better.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira