You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2023/01/06 02:57:17 UTC

[GitHub] [james-project] chibenwa commented on a diff in pull request #1376: JAMES-3756 Show the list of accounts being delegated accounts in JMAP session

chibenwa commented on code in PR #1376:
URL: https://github.com/apache/james-project/pull/1376#discussion_r1063056555


##########
mailbox/api/src/main/java/org/apache/james/mailbox/MailboxSession.java:
##########
@@ -173,6 +178,10 @@ public Optional<Username> getLoggedInUser() {
         return loggedInUser;
     }
 
+    public Set<Username> getDelegatedUsers() {
+        return delegatedUsers;
+    }
+

Review Comment:
   I do not think this is a good idea to carry over this information within the MailboxSession.
   
   This might change.
   
   I would prefer to do a read to the DB.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org