[jira] [Commented] (AMBARI-1846) Arguments passed to PostgresConnector and OracleConnector constructors are in the wrong order

["Billie Rinaldi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMBARI-1846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626988#comment-13626988 ] 

Billie Rinaldi commented on AMBARI-1846:
----------------------------------------

Also, the default values of DEFAULT_DRIVER and DEFAULT_URL are not a driver and a url.  This isn't causing an error because the values of these variables are set again before use, but it's confusing.  (This begs the question of why variables whose values are changed are called DEFAULT_*, but that's just a naming concern.)
                
> Arguments passed to PostgresConnector and OracleConnector constructors are in the wrong order
> ---------------------------------------------------------------------------------------------
>
>                 Key: AMBARI-1846
>                 URL: https://issues.apache.org/jira/browse/AMBARI-1846
>             Project: Ambari
>          Issue Type: Bug
>          Components: client
>            Reporter: Billie Rinaldi
>             Fix For: 1.3.0
>
>
> In WorkflowJsonService:
> {code:java}
>     if (StringUtils.contains(DEFAULT_DRIVER, "oracle")) {
>       return new OracleConnector(DEFAULT_DRIVER, DEFAULT_URL, DEFAULT_USERNAME, DEFAULT_PASSWORD);
>     } else {
>       return new PostgresConnector(DEFAULT_DRIVER, DEFAULT_URL, DEFAULT_USERNAME, DEFAULT_PASSWORD);
>     }
> {code}
> In PostgresConnector (and similarly for OracleConnector):
> {code:java}
>   public PostgresConnector(String connectionURL, String driverName, String username, String password) throws IOException {
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira