You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by ta...@apache.org on 2021/01/06 14:21:00 UTC

[skywalking] 01/02: feature: sampling works when trace ignored plugin activated.

This is an automated email from the ASF dual-hosted git repository.

tanjian pushed a commit to branch feature/sample_when_ignored
in repository https://gitbox.apache.org/repos/asf/skywalking.git

commit 51cd526a6382230cea037e44740f8ea3514eadf0
Author: JaredTan95 <ji...@daocloud.io>
AuthorDate: Wed Jan 6 22:18:53 2021 +0800

    feature: sampling works  when trace ignored plugin activated.
---
 .../apm/plugin/trace/ignore/TraceIgnoreExtendService.java           | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java b/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java
index 71341cd..f826838 100644
--- a/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java
+++ b/apm-sniffer/optional-plugins/trace-ignore-plugin/src/main/java/org/apache/skywalking/apm/plugin/trace/ignore/TraceIgnoreExtendService.java
@@ -37,6 +37,8 @@ public class TraceIgnoreExtendService extends SamplingService {
 
     @Override
     public void boot() {
+        super.boot();
+
         IgnoreConfigInitializer.initialize();
         if (StringUtil.isNotEmpty(IgnoreConfig.Trace.IGNORE_PATH)) {
             patterns = IgnoreConfig.Trace.IGNORE_PATH.split(PATTERN_SEPARATOR);
@@ -53,6 +55,7 @@ public class TraceIgnoreExtendService extends SamplingService {
 
     @Override
     public void shutdown() {
+        super.shutdown();
     }
 
     @Override
@@ -65,10 +68,11 @@ public class TraceIgnoreExtendService extends SamplingService {
                 }
             }
         }
-        return true;
+        return super.trySampling(operationName);
     }
 
     @Override
     public void forceSampled() {
+        super.forceSampled();
     }
 }