You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/04/17 08:15:17 UTC

[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2211: add zk listener remove to avoid memory leak.

codecov-commenter commented on PR #2211:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2211#issuecomment-1510904309

   ## [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2211](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5cec03d) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5f82c4256b28411c84cdc7011bb05022bd1d7179?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f82c42) will **increase** coverage by `0.11%`.
   > The diff coverage is `96.15%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2211      +/-   ##
   ============================================
   + Coverage     84.56%   84.68%   +0.11%     
   - Complexity     1917     1928      +11     
   ============================================
     Files           287      287              
     Lines          6291     6314      +23     
     Branches        696      700       +4     
   ============================================
   + Hits           5320     5347      +27     
   + Misses          649      646       -3     
   + Partials        322      321       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9lbGFzdGljam9iLXJlZ2l0cnktY2VudGVyLXByb3ZpZGVyL2VsYXN0aWNqb2ItcmVnaXN0cnktY2VudGVyLXpvb2tlZXBlci1jdXJhdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL3JlZy96b29rZWVwZXIvWm9va2VlcGVyUmVnaXN0cnlDZW50ZXIuamF2YQ==) | `67.80% <95.23%> (+4.90%)` | :arrow_up: |
   | [...re/elasticjob/lite/internal/setup/SetUpFacade.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc2V0dXAvU2V0VXBGYWNhZGUuamF2YQ==) | `95.23% <100.00%> (+1.12%)` | :arrow_up: |
   | [...asticjob/lite/internal/storage/JobNodeStorage.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc3RvcmFnZS9Kb2JOb2RlU3RvcmFnZS5qYXZh) | `95.34% <100.00%> (ø)` | |
   
   ... and [1 file with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2211/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org