[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6725: Explicitly enable lead controller resource

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #6725:
URL: https://github.com/apache/incubator-pinot/pull/6725#discussion_r603644640



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/util/HelixSetupUtils.java
##########
@@ -205,10 +205,10 @@ private static void createLeadControllerResourceIfNeeded(String helixClusterName
     if (resourceConfig == null) {
       resourceConfig = new ResourceConfig(LEAD_CONTROLLER_RESOURCE_NAME);
     }
-    // Set RESOURCE_ENABLED to false if it's absent in resource config
-    if (resourceConfig.getSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY) == null) {
-      resourceConfig.putSimpleConfig(LEAD_CONTROLLER_RESOURCE_ENABLED_KEY, Boolean.FALSE.toString());
-    }
+    // Explicitly set RESOURCE_ENABLED to true, so that the lead controller resource is always enabled.
+    // This is to help keep the behavior consistent in all clusters for better maintenance.
+    // TODO: remove the logic of handling this config in both controller and server in the next official release.

Review comment:
       Clarify "in the next official release". Do you want to remove it _after_ the next release is done, or _before_ the next release? If _before_, then you can do it now.
   
   Also, please tag this PR for release notes and add appropriate comments that can be noted by whoever is building the release. Questions to be addressed in checkin comments:
   - What is the difference in new cluster creation before and after this commit?
   - How will existing clusters behave after the release when this code is installed?
   - How to find out which controller is "responsible" for a table? (add link to the doc to the rest api. Doc it if it is not already there)
   
   Add a pointer to the design doc.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org