You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by hsyuan <gi...@git.apache.org> on 2016/08/05 21:56:03 UTC
[GitHub] incubator-hawq pull request #839: HAWQ-983. Fix bug that minirepro generates...
GitHub user hsyuan opened a pull request:
https://github.com/apache/incubator-hawq/pull/839
HAWQ-983. Fix bug that minirepro generates wrong dependency order of objects
This patch changes gp_dump_query_oids by traversing the parsed query
tree instead of traversing the query tree struct, which has too
many node type and corner cases to consider. Even it is a little bit
risky to traverse the pased query tree string, we haven't seen any
sign that postgresql upstream is going to change the format.
Add 2 options: relation-oids and function-oids into pg_dump command
line tool to help minirepro dump all the objects in correct order.
In addition, we also fix a minirepro python script bug when column
stats has text type most common values that containing single quote,
minirepro failed to escape that text, which causes sql grammar error
and can't insert that statistics.
Update minirepro to deal with error messages correctly, set PGUSER
as default user, let output file accept relative path.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsyuan/incubator-hawq HAWQ-983
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/839.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #839
----
commit 3691f5e41ac75185420bf6f03e3a9a9c7910576e
Author: Haisheng Yuan <hy...@pivotal.io>
Date: 2016-08-05T21:50:35Z
HAWQ-983. Fix bug that minirepro generates wrong dependency order of objects
This patch changes gp_dump_query_oids by traversing the parsed query
tree instead of traversing the query tree struct, which has too
many node type and corner cases to consider. Even it is a little bit
risky to traverse the pased query tree string, we haven't seen any
sign that postgresql upstream is going to change the format.
Add 2 options: relation-oids and function-oids into pg_dump command
line tool to help minirepro dump all the objects in correct order.
In addition, we also fix a minirepro python script bug when column
stats has text type most common values that containing single quote,
minirepro failed to escape that text, which causes sql grammar error
and can't insert that statistics.
Update minirepro to deal with error messages correctly, set PGUSER
as default user, let output file accept relative path.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
ping, will anyone work on merging this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #839: HAWQ-983. Fix bug that minirepro generates...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan closed the pull request at:
https://github.com/apache/incubator-hawq/pull/839
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
@d @oarap please take a look. This is ported from gpdb.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
@changleicn @liming01 Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by oarap <gi...@git.apache.org>.
Github user oarap commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
Pushed to master:
https://github.com/apache/incubator-hawq/commit/19124b7da032b61d9215520483b67a109246e363
https://github.com/apache/incubator-hawq/commit/08a1c6c2af705df850b1b9bbd6188d0cd2036b42
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #839: HAWQ-983. Fix bug that minirepro generates wrong ...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the issue:
https://github.com/apache/incubator-hawq/pull/839
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---