You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2018/06/06 20:50:07 UTC
[Impala-ASF-CR](2.x) IMPALA-7105. Ensure fe tests pass when running standalone
Hello Vuk Ercegovac, Impala Public Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10620
to review the following change.
Change subject: IMPALA-7105. Ensure fe tests pass when running standalone
......................................................................
IMPALA-7105. Ensure fe tests pass when running standalone
CatalogTest and HdfsStorageDescriptorTest would fail when run
individually because they relied on various initialization that only
occurs when FeSupport is loaded. These tests weren't explicitly loading
FeSupport, but instead relying on earlier tests in 'mvn test' to do so.
Tested that, with this change, I'm able to run these tests in Eclipse
and they pass. I also tested 'mvn test -DreuseForks=false' and verified
that all tests now pass in this mode.
Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Reviewed-on: http://gerrit.cloudera.org:8080/10570
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
4 files changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/10620/1
--
To view, visit http://gerrit.cloudera.org:8080/10620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Gerrit-Change-Number: 10620
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7105. Ensure fe tests pass when running standalone
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10620 )
Change subject: IMPALA-7105. Ensure fe tests pass when running standalone
......................................................................
Patch Set 1: Code-Review+2
Clean pick
--
To view, visit http://gerrit.cloudera.org:8080/10620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Gerrit-Change-Number: 10620
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Wed, 06 Jun 2018 21:05:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR](2.x) IMPALA-7105. Ensure fe tests pass when running standalone
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10620 )
Change subject: IMPALA-7105. Ensure fe tests pass when running standalone
......................................................................
IMPALA-7105. Ensure fe tests pass when running standalone
CatalogTest and HdfsStorageDescriptorTest would fail when run
individually because they relied on various initialization that only
occurs when FeSupport is loaded. These tests weren't explicitly loading
FeSupport, but instead relying on earlier tests in 'mvn test' to do so.
Tested that, with this change, I'm able to run these tests in Eclipse
and they pass. I also tested 'mvn test -DreuseForks=false' and verified
that all tests now pass in this mode.
Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Reviewed-on: http://gerrit.cloudera.org:8080/10570
Reviewed-by: Vuk Ercegovac <ve...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/10620
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/service/FeSupport.java
M fe/src/test/java/org/apache/impala/catalog/CatalogTest.java
M fe/src/test/java/org/apache/impala/catalog/HdfsStorageDescriptorTest.java
M fe/src/test/java/org/apache/impala/testutil/CatalogServiceTestCatalog.java
4 files changed, 14 insertions(+), 3 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Gerrit-Change-Number: 10620
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR](2.x) IMPALA-7105. Ensure fe tests pass when running standalone
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10620 )
Change subject: IMPALA-7105. Ensure fe tests pass when running standalone
......................................................................
Patch Set 1: Verified+1
Verified with https://gerrit.cloudera.org/#/c/10623/
--
To view, visit http://gerrit.cloudera.org:8080/10620
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: 2.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I85286ba44f03526b487212a8ddadf71a9f427555
Gerrit-Change-Number: 10620
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 00:23:23 +0000
Gerrit-HasComments: No