You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/09/14 10:11:16 UTC
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1602: [improve] In the on yarn mode, when there are too many jobs, the numb…
wolfboys commented on code in PR #1602:
URL: https://github.com/apache/incubator-streampark/pull/1602#discussion_r970605025
##########
streampark-flink/streampark-flink-submit/streampark-flink-submit-core/src/main/scala/org/apache/streampark/flink/submit/impl/YarnPerJobSubmit.scala:
##########
@@ -101,14 +101,15 @@ object YarnPerJobSubmit extends YarnSubmitTrait {
}
val applicationId = clusterClient.getClusterId
+ val jobManagerUrl = clusterClient.getWebInterfaceURL
logInfo(
s"""
|-------------------------<<applicationId>>------------------------
|Flink Job Started: applicationId: $applicationId
|__________________________________________________________________
|""".stripMargin)
- SubmitResponse(applicationId.toString, flinkConfig.toMap)
+ SubmitResponse(applicationId.toString, flinkConfig.toMap, "", jobManagerUrl)
Review Comment:
you can improve this code: SubmitResponse(applicationId.toString, flinkConfig.toMap, jobManagerUrl = jobManagerUrl);
##########
streampark-flink/streampark-flink-submit/streampark-flink-submit-core/src/main/scala/org/apache/streampark/flink/submit/impl/YarnApplicationSubmit.scala:
##########
@@ -121,16 +121,18 @@ object YarnApplicationSubmit extends YarnSubmitTrait {
val applicationConfiguration = ApplicationConfiguration.fromConfiguration(flinkConfig)
var applicationId: ApplicationId = null
+ var jobManagerUrl: String = null
clusterClient = clusterDescriptor.deployApplicationCluster(clusterSpecification, applicationConfiguration).getClusterClient
applicationId = clusterClient.getClusterId
+ jobManagerUrl = clusterClient.getWebInterfaceURL;
logInfo(
s"""
|-------------------------<<applicationId>>------------------------
|Flink Job Started: applicationId: $applicationId
|__________________________________________________________________
|""".stripMargin)
- SubmitResponse(applicationId.toString, flinkConfig.toMap)
+ SubmitResponse(applicationId.toString, flinkConfig.toMap, "", jobManagerUrl);
Review Comment:
you can improve this code: SubmitResponse(applicationId.toString, flinkConfig.toMap, jobManagerUrl = jobManagerUrl);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org