[GitHub] [accumulo] ctubbsii commented on a change in pull request #1944: Closes #1929. Add property verification for Sampler Options

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1944:
URL: https://github.com/apache/accumulo/pull/1944#discussion_r580350037



##########
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##########
@@ -1352,6 +1352,17 @@ public static boolean isValidZooPropertyKey(String key) {
         || key.startsWith(REPLICATION_PREFIX.getKey());
   }
 
+  /**
+   * Checks if the given sampler option is valid
+   *
+   * @param option
+   *          property option
+   * @return true if option is a valid sampler option
+   */
+  public static boolean isValidSamplerOption(String option) {
+    return option.endsWith("hasher") || option.endsWith("modules");
+  }
+

Review comment:
       Sampler options are arbitrary, and implementation-specific. The available options depend on the user's provided sampler implementation. They do not have to only be one of these options. These are merely example properties placed in the docs that an implementation might have.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org