You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2024/05/17 16:11:02 UTC
(hbase) branch branch-2 updated: HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.destroy() (#5913)
This is an automated email from the ASF dual-hosted git repository.
zhangduo pushed a commit to branch branch-2
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2 by this push:
new fcaffb82b19 HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.destroy() (#5913)
fcaffb82b19 is described below
commit fcaffb82b1967aeee7f78f42d84cdde97e4d975f
Author: Duo Zhang <zh...@apache.org>
AuthorDate: Fri May 17 23:35:14 2024 +0800
HBASE-26048 [JDK17] Replace the usage of deprecated API ThreadGroup.destroy() (#5913)
Signed-off-by: Xin Sun <su...@apache.org>
(cherry picked from commit 6c84d3960ff143f9bdd11b8143a6bab505c4e165)
---
.../apache/hadoop/hbase/procedure2/ProcedureExecutor.java | 14 +++++---------
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
index 520db524e33..e0c50c7dc8a 100644
--- a/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
+++ b/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
@@ -694,15 +694,11 @@ public class ProcedureExecutor<TEnvironment> {
worker.awaitTermination();
}
- // Destroy the Thread Group for the executors
- // TODO: Fix. #join is not place to destroy resources.
- try {
- threadGroup.destroy();
- } catch (IllegalThreadStateException e) {
- LOG.error("ThreadGroup {} contains running threads; {}: See STDOUT", this.threadGroup,
- e.getMessage());
- // This dumps list of threads on STDOUT.
- this.threadGroup.list();
+ // log the still active threads, ThreadGroup.destroy is deprecated in JDK17 and it is not
+ // necessary for us to must destroy it here, so we just do a check and log
+ if (threadGroup.activeCount() > 0) {
+ LOG.error("There are still active thread in group {}, see STDOUT", threadGroup);
+ threadGroup.list();
}
// reset the in-memory state for testing